linux-kernel - Re: [PATCH v3 2/3] openrisc: Add pci bus support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220729033728.GA2195022@roeck-us.net>
Date:   Thu, 28 Jul 2022 20:37:28 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Stafford Horne <shorne@...il.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Bjorn Helgaas <helgaas@...nel.org>,
        Arnd Bergmann <arnd@...db.de>, Jonas Bonn <jonas@...thpole.se>,
        Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>,
        Palmer Dabbelt <palmer@...osinc.com>,
        Peter Zijlstra <peterz@...radead.org>,
        openrisc@...ts.librecores.org
Subject: Re: [PATCH v3 2/3] openrisc: Add pci bus support

On Mon, Jul 25, 2022 at 11:07:36AM +0900, Stafford Horne wrote:
> This patch adds required definitions to allow for PCI buses on OpenRISC.
> This is being tested on the OpenRISC QEMU virt platform which is in
> development.
> 
> OpenRISC does not have IO ports so we keep the definition of
> IO_SPACE_LIMIT and PIO_RESERVED to be 0.
> 
> Note, since commit 66bcd06099bb ("parport_pc: Also enable driver for PCI
> systems") all platforms that support PCI also need to support parallel
> port.  We add a generic header to support compiling parallel port
> drivers, though they generally will not work as they require IO ports.
> 
> Signed-off-by: Stafford Horne <shorne@...il.com>

This patch results in

Building openrisc:allmodconfig ... failed
--------------
Error log:
drivers/video/fbdev/riva/fbdev.c: In function 'rivafb_probe':
drivers/video/fbdev/riva/fbdev.c:2062:42: error:
	passing argument 1 of 'iounmap' discards 'volatile' qualifier from pointer target type

drivers/video/fbdev/nvidia/nvidia.c: In function 'nvidiafb_probe':
drivers/video/fbdev/nvidia/nvidia.c:1414:20: error:
	passing argument 1 of 'iounmap' discards 'volatile' qualifier from pointer target type

drivers/scsi/aic7xxx/aic7xxx_osm.c: In function 'ahc_platform_free':
drivers/scsi/aic7xxx/aic7xxx_osm.c:1231:41: error:
	passing argument 1 of 'iounmap' discards 'volatile' qualifier from pointer target type

... and so on.

Prior to this patch, the code was not enabled because it depends on PCI.

Bisect log attached.

Guenter

---
# bad: [7c5e07b73ff3011c9b82d4a3286a3362b951ad2b] Add linux-next specific files for 20220728
# good: [e0dccc3b76fb35bb257b4118367a883073d7390e] Linux 5.19-rc8
git bisect start 'HEAD' 'v5.19-rc8'
# bad: [96bce6a87ad9690eaa9b1ca9ace7c98444d7869f] Revert "Revert "drm/amdgpu: add drm buddy support to amdgpu""
git bisect bad 96bce6a87ad9690eaa9b1ca9ace7c98444d7869f
# bad: [08765bd733f4662c2ad80e813c933758b3c1dddc] Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git
git bisect bad 08765bd733f4662c2ad80e813c933758b3c1dddc
# good: [d40269b953fd9abba9aadaa57c6486990ab806d1] Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git
git bisect good d40269b953fd9abba9aadaa57c6486990ab806d1
# bad: [3d810ed5c60843645c6a40cc5ebd66e399c94165] Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux.git
git bisect bad 3d810ed5c60843645c6a40cc5ebd66e399c94165
# good: [046537a939b089589a1a6e70df16b10a8f0c8ca8] Merge branch 'clk-next' of git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git
git bisect good 046537a939b089589a1a6e70df16b10a8f0c8ca8
# good: [d6b551b8f90cc92c7d3c09cf38c748efe305ecb4] powerpc/64e: Fix build failure with GCC 12 (unrecognized opcode: `wrteei')
git bisect good d6b551b8f90cc92c7d3c09cf38c748efe305ecb4
# bad: [e30727fee2a25176c4558f49a102524eba973d49] Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git
git bisect bad e30727fee2a25176c4558f49a102524eba973d49
# bad: [36c4dbb3e78602ee750e12c85fadb3da4392eeac] Merge branch 'for-next' of git://github.com/openrisc/linux.git
git bisect bad 36c4dbb3e78602ee750e12c85fadb3da4392eeac
# good: [9db5e69af1f4de043ae962a908fc7ef1a40f7f51] Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/gerg/m68knommu.git
git bisect good 9db5e69af1f4de043ae962a908fc7ef1a40f7f51
# good: [62fb295ce7dd9df3e04b48a943f8cafaf1f32980] MIPS: dts: align gpio-key node names with dtschema
git bisect good 62fb295ce7dd9df3e04b48a943f8cafaf1f32980
# bad: [2479c96f5d3db2610a6d463077dd3dad087529fb] openrisc: Add virt defconfig
git bisect bad 2479c96f5d3db2610a6d463077dd3dad087529fb
# good: [a2912b45b0826c6fc0ca9b264d03a2dacb7a72e8] asm-generic: Add new pci.h and use it
git bisect good a2912b45b0826c6fc0ca9b264d03a2dacb7a72e8
# good: [3e2a6fbbbf34d230b9063f1ca885d5d625a0404c] asm-generic: Support NO_IOPORT_MAP in pci_iomap.h
git bisect good 3e2a6fbbbf34d230b9063f1ca885d5d625a0404c
# bad: [48ef4b584af7ba4ecdf2dd58b641fb8d0a9d0c63] openrisc: Add pci bus support
git bisect bad 48ef4b584af7ba4ecdf2dd58b641fb8d0a9d0c63
# first bad commit: [48ef4b584af7ba4ecdf2dd58b641fb8d0a9d0c63] openrisc: Add pci bus support