linux-kernel - Re: [PATCH 2/6] hugetlb_cgroup: remove unneeded header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <23841f02-2611-6945-868f-f8f15c325219@huawei.com>
Date:   Fri, 29 Jul 2022 09:07:12 +0800
From:   Miaohe Lin <linmiaohe@...wei.com>
To:     Mina Almasry <almasrymina@...gle.com>
CC:     <akpm@...ux-foundation.org>, <mike.kravetz@...cle.com>,
        <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/6] hugetlb_cgroup: remove unneeded header file

On 2022/7/29 2:02, Mina Almasry wrote:
> On Thu, Jul 28, 2022 at 10:45 AM Mina Almasry <almasrymina@...gle.com> wrote:
>>
>> On Thu, Jul 28, 2022 at 5:20 AM Miaohe Lin <linmiaohe@...wei.com> wrote:
>>>
>>> The header file slab.h is unneeded now. Remove it.
>>>
>>> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
>>
>> Acked-by: Mina Almasry <almasrymina@...gle.com>
>>
> 
> Actually, sorry, but this file calls kzalloc_node() which comes from
> linux/slab.h, no? Can we keep the include then? slab.h is probably
> included by other include files but for clarity it's better that
> hugetlb_cgroup.c to include slab.h if it is calling functions declared
> there.

I have browsed the code to verify it but I still missed kzalloc_node in this file.
Will drop this patch. Many thanks for your review.

> 
>>> ---
>>>  mm/hugetlb_cgroup.c | 1 -
>>>  1 file changed, 1 deletion(-)
>>>
>>> diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c
>>> index d16eb00c947d..99e9a367e1e5 100644
>>> --- a/mm/hugetlb_cgroup.c
>>> +++ b/mm/hugetlb_cgroup.c
>>> @@ -19,7 +19,6 @@
>>>
>>>  #include <linux/cgroup.h>
>>>  #include <linux/page_counter.h>
>>> -#include <linux/slab.h>
>>>  #include <linux/hugetlb.h>
>>>  #include <linux/hugetlb_cgroup.h>
>>>
>>> --
>>> 2.23.0
>>>
> .
>