[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <YuO3/faROPV6p4sU@gondor.apana.org.au>
Date: Fri, 29 Jul 2022 18:35:41 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Gilad Ben-Yossef <gilad@...yossef.com>,
"David S. Miller" <davem@...emloft.net>,
linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
Christoph Hellwig <hch@...radead.org>,
linux-crypto@...r.kernel.org
Subject: Re: [PATCH v2] crypto: ccree - Remove a useless dma_supported() call
On Wed, Jul 20, 2022 at 03:28:44PM +0200, Christophe JAILLET wrote:
> There is no point in calling dma_supported() before calling
> dma_set_coherent_mask(). This function already calls dma_supported() and
> returns an error (-EIO) if it fails.
>
> So remove the superfluous dma_supported() call.
>
> Moreover, setting a larger DMA mask will never fail when setting a smaller
> one will succeed, so the whole "while" loop can be removed as well. (see
> [1])
>
> While at it, fix the name of the function reported in a dev_err().
>
> [1]: https://lore.kernel.org/all/YteQ6Vx2C03UtCkG@infradead.org/
>
> Suggested-by: Christoph Hellwig <hch@...radead.org>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> drivers/crypto/ccree/cc_driver.c | 13 +++----------
> 1 file changed, 3 insertions(+), 10 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Powered by blists - more mailing lists