linux-kernel - Re: [PATCH] KVM: SVM: Dump Virtual Machine Save Area (VMSA) to klog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YuPMeWX4uuR1Tz3M@kernel.org>
Date:   Fri, 29 Jul 2022 15:03:05 +0300
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     Jarkko Sakkinen <jarkko@...fian.com>,
        Harald Hoyer <harald@...fian.com>,
        Sean Christopherson <seanjc@...gle.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>,
        "open list:KERNEL VIRTUAL MACHINE FOR X86 (KVM/x86)" 
        <kvm@...r.kernel.org>,
        "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" 
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] KVM: SVM: Dump Virtual Machine Save Area (VMSA) to klog

On Thu, Jul 28, 2022 at 05:15:43PM +0200, Paolo Bonzini wrote:
> On 7/28/22 07:09, Jarkko Sakkinen wrote:
> > As Virtual Machine Save Area (VMSA) is essential in troubleshooting
> > attestation, dump it to the klog with the KERN_DEBUG level of priority.
> > 
> > Cc: Jarkko Sakkinen <jarkko@...nel.org>
> > Suggested-by: Harald Hoyer <harald@...fian.com>
> > Signed-off-by: Jarkko Sakkinen <jarkko@...fian.com>
> > ---
> >   arch/x86/kvm/svm/sev.c | 3 +++
> >   1 file changed, 3 insertions(+)
> > 
> > diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c
> > index 0c240ed04f96..6d44aaba321a 100644
> > --- a/arch/x86/kvm/svm/sev.c
> > +++ b/arch/x86/kvm/svm/sev.c
> > @@ -603,6 +603,9 @@ static int sev_es_sync_vmsa(struct vcpu_svm *svm)
> >   	save->xss  = svm->vcpu.arch.ia32_xss;
> >   	save->dr6  = svm->vcpu.arch.dr6;
> > +	pr_debug("Virtual Machine Save Area (VMSA):\n");
> > +	print_hex_dump(KERN_CONT, "", DUMP_PREFIX_NONE, 16, 1, save, sizeof(*save), false);
> > +
> >   	return 0;
> >   }
> 
> Queued, thanks.
> 
> Paolo

Ugh, I made a mistake, sorry. 

It should have been:

print_hex_dump(KERN_DEBUG, "VMSA:", DUMP_PREFIX_NONE, 16, 1, save, sizeof(*save), false);

I sent wrong version of the patch.

BR, Jarkko