linux-kernel - Re: [PATCH 1/3] ARM: dts: qcom: msm8960: add reference to sleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 29 Jul 2022 15:10:25 +0300
From:   Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To:     Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Shinjo Park <peremen@...il.com>
Cc:     David Heidelberg <david@...t.cz>, Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] ARM: dts: qcom: msm8960: add reference to sleep_clk

On 29/07/2022 15:01, Konrad Dybcio wrote:
> 
> 
> On 29.07.2022 13:33, Dmitry Baryshkov wrote:
>> On 28/07/2022 14:51, Krzysztof Kozlowski wrote:
>>> On 28/07/2022 13:16, Shinjo Park wrote:
>>>> Change the reference of sleep_clk to the same as qcom-apq8064.dtsi.
>>>
>>> You add label, not change something.
>>>
>>>>
>>>> Signed-off-by: Shinjo Park <peremen@...il.com>
>>>> Reviewed-by: David Heidelberg <david@...t.cz>
>>>> ---
>>>>    arch/arm/boot/dts/qcom-msm8960.dtsi | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/arm/boot/dts/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom-msm8960.dtsi
>>>> index e8cd1c9c0..991eb1948 100644
>>>> --- a/arch/arm/boot/dts/qcom-msm8960.dtsi
>>>> +++ b/arch/arm/boot/dts/qcom-msm8960.dtsi
>>>> @@ -71,7 +71,7 @@ pxo_board: pxo_board {
>>>>                clock-output-names = "pxo_board";
>>>>            };
>>>>    -        sleep_clk {
>>>> +        sleep_clk: sleep_clk {
>>>
>>> Since you touch the line, make the device node sleep-clk (device node
>>> names should not have underscores) and mention this in commit msg.
>>
>>
>> Then we are back to the compat issues, since the gcc expects the 'sleep_clk' clock.
> clock-output-names = "sleep_clk";

Ack then. Didn't notice that msm8960 has one.


-- 
With best wishes
Dmitry