linux-kernel - Re: [PATCH 1/3] LoongArch: Add guess unwinder support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b49c5d32-81fb-0c56-16cc-8fe6cafa3957@loongson.cn>
Date:   Fri, 29 Jul 2022 10:28:31 +0800
From:   Jinyang He <hejinyang@...ngson.cn>
To:     Youling Tang <tangyouling@...ngson.cn>,
        Qing Zhang <zhangqing@...ngson.cn>,
        Huacai Chen <chenhuacai@...nel.org>
Cc:     WANG Xuerui <kernel@...0n.name>, loongarch@...ts.linux.dev,
        linux-kernel@...r.kernel.org, Jiaxun Yang <jiaxun.yang@...goat.com>
Subject: Re: [PATCH 1/3] LoongArch: Add guess unwinder support

Hi, Youling,

[...]
>> +unsigned long unwind_get_return_address(struct unwind_state *state)
>> +{
>> +    if (unwind_done(state))
>> +        return 0;
> This judgment can be removed, because unwind_done() has been judged
> before entering this function, and unwind_get_return_address will not
> be called if it is true.
These unwinder functions are exported by "EXPORT_SYMBOL_GPL".
What's more, new ways to use them will be added in the future possible.
Assuming has judged unwind_done is not reliable.

Thanks,
Jinyang