linux-kernel - Re: [PATCH] staging: pi433: fix wrong comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YuP+ZECjYV6KyFcB@kroah.com>
Date:   Fri, 29 Jul 2022 17:36:04 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Sidong Yang <realwakka@...il.com>
Cc:     Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: pi433: fix wrong comment

On Fri, Jul 29, 2022 at 04:25:54PM +0100, Sidong Yang wrote:
> The comment should describe the error when user calls rf69_write_fifo()
> not rf69_write_fifo().
> 
> Signed-off-by: Sidong Yang <realwakka@...il.com>
> ---
>  drivers/staging/pi433/rf69.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
> index 659c8c1b38fd..8c7fab6a46bb 100644
> --- a/drivers/staging/pi433/rf69.c
> +++ b/drivers/staging/pi433/rf69.c
> @@ -816,7 +816,7 @@ int rf69_write_fifo(struct spi_device *spi, u8 *buffer, unsigned int size)
>  
>  	if (size > FIFO_SIZE) {
>  		dev_dbg(&spi->dev,
> -			"read fifo: passed in buffer bigger then internal buffer\n");
> +			"write fifo: passed in buffer bigger then internal buffer\n");

This is not a comment.