linux-kernel - Re: [PATCH net v1 1/1] net: dsa: microchip: KSZ9893: do not write to not supported Output Clock Control Register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220729163220.GE10850@pengutronix.de>
Date:   Fri, 29 Jul 2022 18:32:20 +0200
From:   Oleksij Rempel <o.rempel@...gutronix.de>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Woojung Huh <woojung.huh@...rochip.com>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, UNGLinuxDriver@...rochip.com,
        Eric Dumazet <edumazet@...gle.com>, kernel@...gutronix.de,
        Paolo Abeni <pabeni@...hat.com>,
        Vladimir Oltean <olteanv@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>
Subject: Re: [PATCH net v1 1/1] net: dsa: microchip: KSZ9893: do not write to
 not supported Output Clock Control Register

On Fri, Jul 29, 2022 at 08:41:49AM -0700, Jakub Kicinski wrote:
> On Fri, 29 Jul 2022 11:48:40 +0200 Oleksij Rempel wrote:
> > On Thu, Jul 28, 2022 at 10:23:16PM -0700, Jakub Kicinski wrote:
> > > On Thu, 28 Jul 2022 15:18:52 +0200 Oleksij Rempel wrote:  
> > > > KSZ9893 compatible chips do not have "Output Clock Control Register 0x0103".
> > > > So, avoid writing to it.  
> > > 
> > > Respin will be needed regardless of the answer to Andrew - patch does
> > > not apply.  
> > 
> > Hm, this driver was hardly refactored in net-next. I'll better send it
> > against net-next otherwise things will break.
> 
> Probably fine either way, with the net-next patch (i.e. this patch) 
> on the list we shouldn't have problems resolving the conflict correctly.
> 
> The real question is whether it's okay for 5.19 to not have this patch.
> It'd be good to have the user-visible impact specified in the commit
> message.

So far I'm not aware about issues related to this, only warning in the data
sheet:
"RESERVED address space must not be written under any circumstances. Failure
to heed this warning may result in untoward operation and unexpected results."

I have send this patch as part of register access validation patch set.
There are move fixes any way.

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |