| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202207300051.IoNQt2j6-lkp@intel.com>
Date: Sat, 30 Jul 2022 00:52:00 +0800
From: kernel test robot <lkp@...el.com>
To: "Jason A. Donenfeld" <zx2c4@...nel.org>
Cc: llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
Ammar Faizi <ammarfaizi2@...weeb.org>,
GNU/Weeb Mailing List <gwml@...r.gnuweeb.org>,
linux-kernel@...r.kernel.org
Subject: [ammarfaizi2-block:crng/random/jd/vdso 8/8]
arch/riscv/include/asm/vdso/gettimeofday.h:21:31: error: use of undeclared
identifier '__NR_gettimeofday'; did you mean 'sys_gettimeofday'?
tree: https://github.com/ammarfaizi2/linux-block crng/random/jd/vdso
head: 02d56061c924adece19bdfad05ea4add32de4b63
commit: 02d56061c924adece19bdfad05ea4add32de4b63 [8/8] random: implement getrandom() in vDSO
config: riscv-randconfig-r042-20220729 (https://download.01.org/0day-ci/archive/20220730/202207300051.IoNQt2j6-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 8dfaecc4c24494337933aff9d9166486ca0949f1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv-linux-gnu
# https://github.com/ammarfaizi2/linux-block/commit/02d56061c924adece19bdfad05ea4add32de4b63
git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
git fetch --no-tags ammarfaizi2-block crng/random/jd/vdso
git checkout 02d56061c924adece19bdfad05ea4add32de4b63
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/char/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
In file included from drivers/char/random.c:62:
In file included from include/vdso/datapage.h:143:
>> arch/riscv/include/asm/vdso/gettimeofday.h:21:31: error: use of undeclared identifier '__NR_gettimeofday'; did you mean 'sys_gettimeofday'?
register long nr asm("a7") = __NR_gettimeofday;
^~~~~~~~~~~~~~~~~
sys_gettimeofday
include/linux/syscalls.h:775:17: note: 'sys_gettimeofday' declared here
asmlinkage long sys_gettimeofday(struct __kernel_old_timeval __user *tv,
^
In file included from drivers/char/random.c:62:
In file included from include/vdso/datapage.h:143:
>> arch/riscv/include/asm/vdso/gettimeofday.h:21:16: error: incompatible pointer to integer conversion initializing 'long' with an expression of type 'long (struct __kernel_old_timeval *, struct timezone *)' [-Wint-conversion]
register long nr asm("a7") = __NR_gettimeofday;
^ ~~~~~~~~~~~~~~~~~
>> arch/riscv/include/asm/vdso/gettimeofday.h:37:31: error: use of undeclared identifier '__NR_clock_gettime'; did you mean 'sys_clock_gettime'?
register long nr asm("a7") = __NR_clock_gettime;
^~~~~~~~~~~~~~~~~~
sys_clock_gettime
include/linux/syscalls.h:663:17: note: 'sys_clock_gettime' declared here
asmlinkage long sys_clock_gettime(clockid_t which_clock,
^
In file included from drivers/char/random.c:62:
In file included from include/vdso/datapage.h:143:
>> arch/riscv/include/asm/vdso/gettimeofday.h:37:16: error: incompatible pointer to integer conversion initializing 'long' with an expression of type 'long (clockid_t, struct __kernel_timespec *)' (aka 'long (int, struct __kernel_timespec *)') [-Wint-conversion]
register long nr asm("a7") = __NR_clock_gettime;
^ ~~~~~~~~~~~~~~~~~~
>> arch/riscv/include/asm/vdso/gettimeofday.h:53:31: error: use of undeclared identifier '__NR_clock_getres'; did you mean 'sys_clock_getres'?
register long nr asm("a7") = __NR_clock_getres;
^~~~~~~~~~~~~~~~~
sys_clock_getres
include/linux/syscalls.h:665:17: note: 'sys_clock_getres' declared here
asmlinkage long sys_clock_getres(clockid_t which_clock,
^
In file included from drivers/char/random.c:62:
In file included from include/vdso/datapage.h:143:
arch/riscv/include/asm/vdso/gettimeofday.h:53:16: error: incompatible pointer to integer conversion initializing 'long' with an expression of type 'long (clockid_t, struct __kernel_timespec *)' (aka 'long (int, struct __kernel_timespec *)') [-Wint-conversion]
register long nr asm("a7") = __NR_clock_getres;
^ ~~~~~~~~~~~~~~~~~
>> drivers/char/random.c:88:42: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
DEFINE_VVAR_SINGLE(struct vdso_rng_data, _vdso_rng_data);
^
int
drivers/char/random.c:88:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
DEFINE_VVAR_SINGLE(struct vdso_rng_data, _vdso_rng_data);
^
int
8 errors generated.
vim +21 arch/riscv/include/asm/vdso/gettimeofday.h
ad5d1122b82fbd Vincent Chen 2020-06-09 13
ad5d1122b82fbd Vincent Chen 2020-06-09 14 static __always_inline
ad5d1122b82fbd Vincent Chen 2020-06-09 15 int gettimeofday_fallback(struct __kernel_old_timeval *_tv,
ad5d1122b82fbd Vincent Chen 2020-06-09 16 struct timezone *_tz)
ad5d1122b82fbd Vincent Chen 2020-06-09 17 {
ad5d1122b82fbd Vincent Chen 2020-06-09 18 register struct __kernel_old_timeval *tv asm("a0") = _tv;
ad5d1122b82fbd Vincent Chen 2020-06-09 19 register struct timezone *tz asm("a1") = _tz;
ad5d1122b82fbd Vincent Chen 2020-06-09 20 register long ret asm("a0");
ad5d1122b82fbd Vincent Chen 2020-06-09 @21 register long nr asm("a7") = __NR_gettimeofday;
ad5d1122b82fbd Vincent Chen 2020-06-09 22
ad5d1122b82fbd Vincent Chen 2020-06-09 23 asm volatile ("ecall\n"
ad5d1122b82fbd Vincent Chen 2020-06-09 24 : "=r" (ret)
ad5d1122b82fbd Vincent Chen 2020-06-09 25 : "r"(tv), "r"(tz), "r"(nr)
ad5d1122b82fbd Vincent Chen 2020-06-09 26 : "memory");
ad5d1122b82fbd Vincent Chen 2020-06-09 27
ad5d1122b82fbd Vincent Chen 2020-06-09 28 return ret;
ad5d1122b82fbd Vincent Chen 2020-06-09 29 }
ad5d1122b82fbd Vincent Chen 2020-06-09 30
ad5d1122b82fbd Vincent Chen 2020-06-09 31 static __always_inline
ad5d1122b82fbd Vincent Chen 2020-06-09 32 long clock_gettime_fallback(clockid_t _clkid, struct __kernel_timespec *_ts)
ad5d1122b82fbd Vincent Chen 2020-06-09 33 {
ad5d1122b82fbd Vincent Chen 2020-06-09 34 register clockid_t clkid asm("a0") = _clkid;
ad5d1122b82fbd Vincent Chen 2020-06-09 35 register struct __kernel_timespec *ts asm("a1") = _ts;
ad5d1122b82fbd Vincent Chen 2020-06-09 36 register long ret asm("a0");
ad5d1122b82fbd Vincent Chen 2020-06-09 @37 register long nr asm("a7") = __NR_clock_gettime;
ad5d1122b82fbd Vincent Chen 2020-06-09 38
ad5d1122b82fbd Vincent Chen 2020-06-09 39 asm volatile ("ecall\n"
ad5d1122b82fbd Vincent Chen 2020-06-09 40 : "=r" (ret)
ad5d1122b82fbd Vincent Chen 2020-06-09 41 : "r"(clkid), "r"(ts), "r"(nr)
ad5d1122b82fbd Vincent Chen 2020-06-09 42 : "memory");
ad5d1122b82fbd Vincent Chen 2020-06-09 43
ad5d1122b82fbd Vincent Chen 2020-06-09 44 return ret;
ad5d1122b82fbd Vincent Chen 2020-06-09 45 }
ad5d1122b82fbd Vincent Chen 2020-06-09 46
ad5d1122b82fbd Vincent Chen 2020-06-09 47 static __always_inline
ad5d1122b82fbd Vincent Chen 2020-06-09 48 int clock_getres_fallback(clockid_t _clkid, struct __kernel_timespec *_ts)
ad5d1122b82fbd Vincent Chen 2020-06-09 49 {
ad5d1122b82fbd Vincent Chen 2020-06-09 50 register clockid_t clkid asm("a0") = _clkid;
ad5d1122b82fbd Vincent Chen 2020-06-09 51 register struct __kernel_timespec *ts asm("a1") = _ts;
ad5d1122b82fbd Vincent Chen 2020-06-09 52 register long ret asm("a0");
ad5d1122b82fbd Vincent Chen 2020-06-09 @53 register long nr asm("a7") = __NR_clock_getres;
ad5d1122b82fbd Vincent Chen 2020-06-09 54
ad5d1122b82fbd Vincent Chen 2020-06-09 55 asm volatile ("ecall\n"
ad5d1122b82fbd Vincent Chen 2020-06-09 56 : "=r" (ret)
ad5d1122b82fbd Vincent Chen 2020-06-09 57 : "r"(clkid), "r"(ts), "r"(nr)
ad5d1122b82fbd Vincent Chen 2020-06-09 58 : "memory");
ad5d1122b82fbd Vincent Chen 2020-06-09 59
ad5d1122b82fbd Vincent Chen 2020-06-09 60 return ret;
ad5d1122b82fbd Vincent Chen 2020-06-09 61 }
ad5d1122b82fbd Vincent Chen 2020-06-09 62
:::::: The code at line 21 was first introduced by commit
:::::: ad5d1122b82fbd6a816d1b9d26ee01a6dbc2d757 riscv: use vDSO common flow to reduce the latency of the time-related functions
:::::: TO: Vincent Chen <vincent.chen@...ive.com>
:::::: CC: Palmer Dabbelt <palmerdabbelt@...gle.com>
--
0-DAY CI Kernel Test Service
https://01.org/lkp
Powered by blists - more mailing lists