linux-kernel - Re: [PATCH v5 4/5] vfio/iommu_type1: Clean up update_dirty_scope in detach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YuQaKpvsJICiFC6N@nvidia.com>
Date:   Fri, 29 Jul 2022 14:34:34 -0300
From:   Jason Gunthorpe <jgg@...dia.com>
To:     Nicolin Chen <nicolinc@...dia.com>
Cc:     joro@...tes.org, will@...nel.org, marcan@...can.st,
        sven@...npeter.dev, robin.murphy@....com, robdclark@...il.com,
        baolu.lu@...ux.intel.com, orsonzhai@...il.com,
        baolin.wang7@...il.com, zhang.lyra@...il.com,
        jean-philippe@...aro.org, alex.williamson@...hat.com,
        kevin.tian@...el.com, suravee.suthikulpanit@....com,
        alyssa@...enzweig.io, dwmw2@...radead.org, mjrosato@...ux.ibm.com,
        gerald.schaefer@...ux.ibm.com, thierry.reding@...il.com,
        vdumpa@...dia.com, jonathanh@...dia.com, cohuck@...hat.com,
        thunder.leizhen@...wei.com, christophe.jaillet@...adoo.fr,
        chenxiang66@...ilicon.com, john.garry@...wei.com,
        yangyingliang@...wei.com, iommu@...ts.linux-foundation.org,
        iommu@...ts.linux.dev, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-arm-msm@...r.kernel.org, linux-s390@...r.kernel.org,
        linux-tegra@...r.kernel.org,
        virtualization@...ts.linux-foundation.org, kvm@...r.kernel.org
Subject: Re: [PATCH v5 4/5] vfio/iommu_type1: Clean up update_dirty_scope in
 detach_group()

On Fri, Jul 01, 2022 at 02:44:54PM -0700, Nicolin Chen wrote:
> All devices in emulated_iommu_groups have pinned_page_dirty_scope
> set, so the update_dirty_scope in the first list_for_each_entry
> is always false. Clean it up, and move the "if update_dirty_scope"
> part from the detach_group_done routine to the domain_list part.
> 
> Suggested-by: Jason Gunthorpe <jgg@...dia.com>
> Reviewed-by: Kevin Tian <kevin.tian@...el.com>
> Signed-off-by: Nicolin Chen <nicolinc@...dia.com>
> ---
>  drivers/vfio/vfio_iommu_type1.c | 27 ++++++++++++---------------
>  1 file changed, 12 insertions(+), 15 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@...dia.com>

Jason