linux-kernel - Re: [PATCH] tracing: Do PTR_ERR() after IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <61a8a192-d10a-18f2-94f5-69c0902bb403@nfschina.com>
Date:   Sat, 30 Jul 2022 09:20:06 +0800
From:   李力琼 <liqiong@...china.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
        yuzhe@...china.com, renyu@...china.com, jiaming@...china.com
Subject: Re: [PATCH] tracing: Do PTR_ERR() after IS_ERR()


在 2022/7/30 00:56, Steven Rostedt 写道:
> On Thu, 28 Jul 2022 08:28:08 +0800
> liqiong <liqiong@...china.com> wrote:
>
>> It's all right, assign  PTR_ERR()  to 'ret'  anyway.
>> But this assignment is valid only at the "IS_ERR()" path.
>> Maybe it is better put "PTR_ERR()" at error path, keep the code clear.
> No it does not. It adds unnecessary brackets.
>
> It is common in the kernel to have:
>
> 	ret = ERROR;
> 	if (some_condition())
> 		goto out;
>
> 	ret = ERROR1;
> 	if (some_other_condition())
> 		goto out;
>
> 	ret = ERROR2;
> 	if (some_new_condition())
> 		goto out;
>
> 	ret = 0;
> out:
> 	return ret;
>
> And your change breaks this.
>
> -- Steve

I got it, Thanks.