linux-kernel - Re: Stack-frame warnings in display_mode_vba

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <80410e6e-838b-fa3d-1f87-710eb3c751c5@roeck-us.net>
Date:   Sat, 30 Jul 2022 02:06:10 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     paulmck@...nel.org,
        André Almeida <andrealmeid@...lia.com>
Cc:     sfr@...b.auug.org.au, harry.wentland@....com, sunpeng.li@....com,
        arnd@...db.de, alexander.deucher@....com,
        linux-next@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        amd-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: Stack-frame warnings in display_mode_vba_32.c

On 7/29/22 22:12, Paul E. McKenney wrote:
> On Fri, Jul 29, 2022 at 11:41:55PM -0300, André Almeida wrote:
>> Hi Paul,
>>
>> Às 23:25 de 29/07/22, Paul E. McKenney escreveu:
>>> Hello!
>>>
>>> I am seeing the following in allmodconfig builds of recent -next on x86:
>>>
>>> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c: In function ‘DISPCLKDPPCLKDCFCLKDeepSleepPrefetchParametersWatermarksAndPerformanceCalculation’:
>>> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c:1659:1: error: the frame size of 2144 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
>>>   1659 | }
>>>        | ^
>>> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c: In function ‘dml32_ModeSupportAndSystemConfigurationFull’:
>>> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c:3799:1: error: the frame size of 2480 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
>>>   3799 | } // ModeSupportAndSystemConfigurationFull
>>>        | ^
>>
>> I think they are fixed at amd-staging-drm-next:
>>
>> git log --oneline amd/amd-staging-drm-next
>> drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c
>> 953daa61981b drm/amd/display: Reduce stack size in the mode support function
>> 361e705e712d drm/amd/display: reduce stack for
>> dml32_CalculatePrefetchSchedule
>> f2dbf5a4dd1e drm/amd/display: reduce stack for
>> dml32_CalculateWatermarksMALLUseAndDRAMSpeedChangeSupport
>> a0a68cda2ef8 drm/amd/display: reduce stack for dml32_CalculateVMRowAndSwath
>> ca6730ca0f01 drm/amd/display: reduce stack for
>> dml32_CalculateSwathAndDETConfiguration
>> 593eef8c1a5e drm/amd/display: reduce stack size in dcn32 dml (v2)
>>
>> https://gitlab.freedesktop.org/agd5f/linux/-/commits/amd-staging-drm-next/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c
> 
> Very good, thank you!  I will test again on the next -next.
> 

Did you try next-20220728 ?

groeck@...ver:~/src/linux-next$ git describe
next-20220728
groeck@...ver:~/src/linux-next$ git log --oneline drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c
1b54a0121dba drm/amd/display: Reduce stack size in the mode support function
86e4863e67a9 drm/amd/display: reduce stack for dml32_CalculatePrefetchSchedule
3c3abac60117 drm/amd/display: reduce stack for dml32_CalculateWatermarksMALLUseAndDRAMSpeedChangeSupport
c3b3f9ba25e6 drm/amd/display: reduce stack for dml32_CalculateVMRowAndSwath
bac4b41d917a drm/amd/display: reduce stack for dml32_CalculateSwathAndDETConfiguration
7acc487ab57e drm/amd/display: reduce stack size in dcn32 dml (v2)

Guenter