linux-kernel - Re: [PATCH] MIPS: msi-octeon: eliminate kernel-doc warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 30 Jul 2022 11:02:52 +0200
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>,
        Aditya Srivastava <yashsri421@...il.com>,
        linux-mips@...r.kernel.org
Subject: Re: [PATCH] MIPS: msi-octeon: eliminate kernel-doc warnings

On Sat, Jul 23, 2022 at 10:57:23PM -0700, Randy Dunlap wrote:
> Rearrange kernel-doc notation for 2 functions to eliminate
> kernel-doc warnings. Use Return: notation for the function
> return value description. Add function short descriptions
> for both functions.
> Correct 2 typos.
> 
> Fixes these kernel-doc warnings:
> 
> msi-octeon.c:49: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
>  * Called when a driver request MSI interrupts instead of the
> msi-octeon.c:49: warning: missing initial short description on line:
>  * Called when a driver request MSI interrupts instead of the
> msi-octeon.c:62: warning: No description found for return value of 'arch_setup_msi_irq'
> msi-octeon.c:189: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
>  * Called when a device no longer needs its MSI interrupts. All
> msi-octeon.c:189: warning: missing initial short description on line:
>  * Called when a device no longer needs its MSI interrupts. All
> 
> Fixes: e8635b484f64 ("MIPS: Add Cavium OCTEON PCI support.")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Aditya Srivastava <yashsri421@...il.com>
> Cc: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
> Cc: linux-mips@...r.kernel.org
> ---
>  arch/mips/pci/msi-octeon.c |   16 +++++++++-------
>  1 file changed, 9 insertions(+), 7 deletions(-)

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]