linux-kernel - Re: [PATCH v2 04/10] dt-bindings: iio: dac: use spi-peripheral-props.yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220730224348.GA11662@wunner.de>
Date:   Sun, 31 Jul 2022 00:43:48 +0200
From:   Lukas Wunner <lukas@...ner.de>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Lucas Stankus <lucas.p.stankus@...il.com>,
        Puranjay Mohan <puranjay12@...il.com>,
        Cosmin Tanislav <cosmin.tanislav@...log.com>,
        Alexandru Tachici <alexandru.tachici@...log.com>,
        Marcelo Schmitt <marcelo.schmitt1@...il.com>,
        Marcus Folkesson <marcus.folkesson@...il.com>,
        Kent Gustavsson <kent@...oris.se>,
        Tomislav Denis <tomislav.denis@....com>,
        Oleksij Rempel <linux@...pel-privat.de>, kernel@...gutronix.de,
        Antoniu Miclaus <antoniu.miclaus@...log.com>,
        Ricardo Ribalda <ribalda@...nel.org>,
        Dragos Bogdan <dragos.bogdan@...log.com>,
        Jean-Baptiste Maneyrol <jmaneyrol@...ensense.com>,
        Lorenzo Bianconi <lorenzo@...nel.org>,
        Stefan Popa <stefan.popa@...log.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Stephan Gerhold <stephan@...hold.net>,
        Mike Looijmans <mike.looijmans@...ic.nl>,
        Joachim Eastwood <manabian@...il.com>,
        Tomas Melin <tomas.melin@...sala.com>,
        Sean Nyekjaer <sean@...nix.com>,
        Beniamin Bia <beniamin.bia@...log.com>,
        Patrick Vasseur <patrick.vasseur@....fr>,
        Charles-Antoine Couret <charles-antoine.couret@...ensium.com>,
        Vladimir Barinov <vladimir.barinov@...entembedded.com>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Philippe Reynes <tremyfr@...oo.fr>,
        Jacopo Mondi <jacopo@...ndi.org>,
        Akinobu Mita <akinobu.mita@...il.com>,
        Alexandru Lazar <alazar@...rtmail.com>,
        Oskar Andero <oskar.andero@...il.com>,
        Mårten Lindahl <martenli@...s.com>,
        Bogdan Pricop <bogdan.pricop@...tex.com>,
        Angelo Compagnucci <angelo.compagnucci@...il.com>,
        Matt Ranostay <matt.ranostay@...sulko.com>,
        Dan Murphy <dmurphy@...com>,
        Gregory Clement <gregory.clement@...tlin.com>,
        Phil Reid <preid@...ctromag.com.au>,
        Michael Welling <mwelling@...e.org>,
        Robert Jones <rjones@...eworks.com>,
        Chris Coffey <cmc@...blebit.net>,
        Slawomir Stepien <sst@...zta.fm>,
        Sankar Velliangiri <navin@...umiz.com>,
        linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-fbdev@...r.kernel.org
Subject: Re: [PATCH v2 04/10] dt-bindings: iio: dac: use
 spi-peripheral-props.yaml

On Wed, Jul 27, 2022 at 06:46:40PM +0200, Krzysztof Kozlowski wrote:
> diff --git a/Documentation/devicetree/bindings/iio/dac/ti,dac082s085.yaml b/Documentation/devicetree/bindings/iio/dac/ti,dac082s085.yaml
> index b0157050f1ee..201b04af2b22 100644
> --- a/Documentation/devicetree/bindings/iio/dac/ti,dac082s085.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/ti,dac082s085.yaml
> @@ -33,21 +33,22 @@ properties:
>    vref-supply:
>      description: Needed to provide output scaling.
>  
> -  spi-max-frequency: true
> -
>  required:
>    - compatible
>    - reg
>    - vref-supply
>  
> -additionalProperties: false
> -
>  oneOf:
>    - required:
>        - spi-cpha
>    - required:
>        - spi-cpol
>  
> +allOf:
> +  - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> +unevaluatedProperties: false
> +
>  examples:
>    - |
>      vref_2v5_reg: regulator-vref {

Just to double-check because I'm unsure how the allOf interacts with
the oneOf above:  The DT must specify either spi-cpha or spi-cpol
for this device, but not both.  Hopefully that's still enforced
after your change?

Thanks,

Lukas