linux-kernel - [ambarus:at-hdmac-virt-dma-2nd-iteration 9/11] drivers/dma/at_hdmac.c:469: warning: expecting prototype for set_desc_eol(). Prototype was for set_lli

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sun, 31 Jul 2022 21:28:30 +0800
From:   kernel test robot <lkp@...el.com>
To:     Tudor Ambarus <tudor.ambarus@...il.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [ambarus:at-hdmac-virt-dma-2nd-iteration 9/11]
 drivers/dma/at_hdmac.c:469: warning: expecting prototype for set_desc_eol().
 Prototype was for set_lli_eol() instead

tree:   https://github.com/ambarus/linux-0day at-hdmac-virt-dma-2nd-iteration
head:   ae6fc9abe0bb2ef6193d3353b41ebcd49f7f95a0
commit: e4caf9eb097113115c4ae345da16ce06c9365842 [9/11] dmaengine: at-hdmac: Update driver to use virt-dma
config: arm-at91_dt_defconfig (https://download.01.org/0day-ci/archive/20220731/202207312153.ze7Hqt3a-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/ambarus/linux-0day/commit/e4caf9eb097113115c4ae345da16ce06c9365842
        git remote add ambarus https://github.com/ambarus/linux-0day
        git fetch --no-tags ambarus at-hdmac-virt-dma-2nd-iteration
        git checkout e4caf9eb097113115c4ae345da16ce06c9365842
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/dma/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/dma/at_hdmac.c:251: warning: Function parameter or member 'vd' not described in 'at_desc'
   drivers/dma/at_hdmac.c:251: warning: Function parameter or member 'atchan' not described in 'at_desc'
   drivers/dma/at_hdmac.c:251: warning: Function parameter or member 'sglen' not described in 'at_desc'
   drivers/dma/at_hdmac.c:251: warning: Function parameter or member 'active_xfer' not described in 'at_desc'
   drivers/dma/at_hdmac.c:251: warning: Function parameter or member 'boundary' not described in 'at_desc'
   drivers/dma/at_hdmac.c:251: warning: Function parameter or member 'dst_hole' not described in 'at_desc'
   drivers/dma/at_hdmac.c:251: warning: Function parameter or member 'src_hole' not described in 'at_desc'
   drivers/dma/at_hdmac.c:251: warning: Function parameter or member 'memset_buffer' not described in 'at_desc'
   drivers/dma/at_hdmac.c:251: warning: Function parameter or member 'memset_paddr' not described in 'at_desc'
   drivers/dma/at_hdmac.c:251: warning: Function parameter or member 'memset_vaddr' not described in 'at_desc'
   drivers/dma/at_hdmac.c:251: warning: Function parameter or member 'sg' not described in 'at_desc'
   drivers/dma/at_hdmac.c:259: warning: cannot understand function prototype: 'enum atc_status '
   drivers/dma/at_hdmac.c:292: warning: Function parameter or member 'vc' not described in 'at_dma_chan'
   drivers/dma/at_hdmac.c:292: warning: Function parameter or member 'atdma' not described in 'at_dma_chan'
   drivers/dma/at_hdmac.c:292: warning: Function parameter or member 'sgidx' not described in 'at_dma_chan'
   drivers/dma/at_hdmac.c:292: warning: Function parameter or member 'cyclic' not described in 'at_dma_chan'
   drivers/dma/at_hdmac.c:292: warning: Function parameter or member 'desc' not described in 'at_dma_chan'
   drivers/dma/at_hdmac.c:365: warning: Function parameter or member 'regs' not described in 'at_dma'
   drivers/dma/at_hdmac.c:469: warning: Function parameter or member 'i' not described in 'set_lli_eol'
>> drivers/dma/at_hdmac.c:469: warning: expecting prototype for set_desc_eol(). Prototype was for set_lli_eol() instead
   drivers/dma/at_hdmac.c:708: warning: Function parameter or member 'i' not described in 'atc_handle_error'


vim +469 drivers/dma/at_hdmac.c

807dd140a1f96b Tudor Ambarus 2022-07-04  463  
807dd140a1f96b Tudor Ambarus 2022-07-04  464  /**
807dd140a1f96b Tudor Ambarus 2022-07-04  465   * set_desc_eol - set end-of-link to descriptor so it will end transfer
807dd140a1f96b Tudor Ambarus 2022-07-04  466   * @desc: descriptor, signle or at the end of a chain, to end chain on
807dd140a1f96b Tudor Ambarus 2022-07-04  467   */
e4caf9eb097113 Tudor Ambarus 2022-07-11  468  static void set_lli_eol(struct at_desc *desc, unsigned int i)
807dd140a1f96b Tudor Ambarus 2022-07-04 @469  {
e4caf9eb097113 Tudor Ambarus 2022-07-11  470  	u32 ctrlb = desc->sg[i].lli->ctrlb;
807dd140a1f96b Tudor Ambarus 2022-07-04  471  
807dd140a1f96b Tudor Ambarus 2022-07-04  472  	ctrlb &= ~ATC_IEN;
807dd140a1f96b Tudor Ambarus 2022-07-04  473  	ctrlb |= ATC_SRC_DSCR_DIS | ATC_DST_DSCR_DIS;
807dd140a1f96b Tudor Ambarus 2022-07-04  474  
e4caf9eb097113 Tudor Ambarus 2022-07-11  475  	desc->sg[i].lli->ctrlb = ctrlb;
e4caf9eb097113 Tudor Ambarus 2022-07-11  476  	desc->sg[i].lli->dscr = 0;
807dd140a1f96b Tudor Ambarus 2022-07-04  477  }
807dd140a1f96b Tudor Ambarus 2022-07-04  478  

:::::: The code at line 469 was first introduced by commit
:::::: 807dd140a1f96b66a04811cb693fcc3685110501 dmaengine: at_hdmac: Keep register definitions and structures private to at_hdmac.c

:::::: TO: Tudor Ambarus <tudor.ambarus@...rochip.com>
:::::: CC: Tudor Ambarus <tudor.ambarus@...rochip.com>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp