linux-kernel - Re: [PATCH 2/2] kprobes: fix the comments error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20220731233732.446610618f2f208f13b8e2a1@kernel.org>
Date:   Sun, 31 Jul 2022 23:37:32 +0900
From:   Masami Hiramatsu (Google) <mhiramat@...nel.org>
To:     zhangduo <zduo006@....com>
Cc:     naveen.n.rao@...ux.ibm.com, anil.s.keshavamurthy@...el.com,
        davem@...emloft.net, mhiramat@...nel.org,
        linux-kernel@...r.kernel.org, zhangduo <zhangduo@...inos.cn>
Subject: Re: [PATCH 2/2] kprobes: fix the comments error

On Fri, 22 Jul 2022 14:25:05 +0800
zhangduo <zduo006@....com> wrote:

> From: zhangduo <zhangduo@...inos.cn>
> 
> fix the comments 'Copy the insn slot of ap to p'
> 
> Signed-off-by: zhangduo <zhangduo@...inos.cn>

Looks good to me. 

Acked-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>

Thanks, 

> ---
>  kernel/kprobes.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> index f1dddc8fe..8bcef7d3c 100644
> --- a/kernel/kprobes.c
> +++ b/kernel/kprobes.c
> @@ -1349,7 +1349,7 @@ static int register_aggr_kprobe(struct kprobe *orig_p, struct kprobe *p)
>  			    | KPROBE_FLAG_DISABLED;
>  	}
>  
> -	/* Copy the insn slot of 'p' to 'ap'. */
> +	/* Copy the insn slot of 'ap' to 'p'. */
>  	copy_kprobe(ap, p);
>  	ret = add_new_kprobe(ap, p);
>  
> -- 
> 2.25.1
> 


-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>