linux-kernel - Re: [PATCH v10 0/2] Add LTRF216A Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220731173446.7400bfa8@jic23-huawei>
Date:   Sun, 31 Jul 2022 17:34:46 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Shreeya Patel <shreeya.patel@...labora.com>
Cc:     lars@...afoo.de, robh+dt@...nel.org, Zhigang.Shi@...eon.com,
        dmitry.osipenko@...labora.com, krisman@...labora.com,
        andy.shevchenko@...il.com, linux-iio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...labora.com, alvaro.soliverez@...labora.com
Subject: Re: [PATCH v10 0/2] Add LTRF216A Driver

On Mon, 25 Jul 2022 16:10:48 +0530
Shreeya Patel <shreeya.patel@...labora.com> wrote:

> This patchset adds support for ltrf216a Ambient Light Sensor
> and documents the DT bindings for the same.

Series applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to see if they can find anything we missed.

Thanks for persisting with this!  Note that it will be queued up for
next cycle and that I'll rebase my tree on rc1 once available.
I won't push out as togreg (which is picked up by linux-next) until
after that rebase.

Thanks,

Jonathan

> 
> Changes in v10
>   - Handle !CONFIG_PM scenario similar to how other IIO drivers
>     do it.
>   - Fix kernel test robot warning.
> 
> Changes in v9
>   - Add LTRF216A_MAIN_STATUS register in volatile function.
>   - Update the datasheet link.
> 
> Changes in v8
>   - Add caching mechanism to restore register state after h/w resume.
>   - Add callback functions and disable locking in regmap config.
>   - Update mutex comment as per it's current scope in the driver.
>   - Add Shreeya as author of the driver.
>   - Make some minor cleanups.
> 
> Changes in v7
>   - Add regmap support.
>   - Fix runtime power management implementation.
>   - Fix the ordering of devm and non-devm functions.
>   - Use DEFINE_RUNTIME_DEV_PM_OPS macro
>   - Fix the error reported by kernel test robot for bindings.
> 
> Changes in v6
>   - Fix some errors reported by kernel test robot.
>   - Add protocol details for the datasheet link.
>   - Remove useless assignments.
>   - Add unit details for read data delay macro.
>   - Use pm_sleep_ptr().
> 
> Changes in v5
>   - Add power management support.
>   - Add reset functionality.
>   - Use readx_poll_timeout() to get data.
>   - Cleanup some of the redundant code.
>   - Update int_time_fac after I2C write is successful.
>   - Rename mutex to lock.
>   - Use Reverse Xmas tree pattern for all variable definitions.
>   - Improve error handling messages and add error codes.
>   - Add one more MODULE_AUTHOR.
>   - Remove cleardata which was reading data for infrared light.
>   - Remove patch for deprecated vendor prefix [PATCH v4 3/3].
>   - Remove deprecated string from DT binding document.
> 
> Changes in v4
>   - Add more descriptive comment for mutex lock
>   - Fix mutex locking in read_raw()
>   - Use i2c_smbus_read_i2c_block_data()
> 
> Changes in v3
>   - Use u16 instead of u8 for int_time_fac
>   - Reorder headers in ltrf216a.c file
>   - Remove int_time_mapping table and use int_time_available
>   - Fix indentation in the bindings file.
> 
> Changes in v2
>   - Add support for 25ms and 50ms integration time.
>   - Rename some of the macros as per names given in datasheet
>   - Add a comment for the mutex lock
>   - Use read_avail callback instead of attributes and set the
>     appropriate _available bit.
>   - Use FIELD_PREP() at appropriate places.
>   - Add a constant lookup table for integration time and reg val
>   - Use BIT() macro for magic numbers.
>   - Improve error handling at few places.
>   - Use get_unaligned_le24() and div_u64()
>   - Use probe_new() callback and devm functions
>   - Return errors in probe using dev_err_probe()
>   - Use DEFINE_SIMPLE_DEV_PM_OPS()
>   - Correct the formula for lux to use 0.45 instead of 0.8
>   - Add interrupt and power supply property in DT bindings
>   - Add vendor prefix name as per the alphabetical order.
> 
> 
> Shreeya Patel (2):
>   dt-bindings: Document ltrf216a light sensor bindings
>   iio: light: Add support for ltrf216a sensor
> 
>  .../bindings/iio/light/liteon,ltrf216a.yaml   |  49 ++
>  drivers/iio/light/Kconfig                     |  11 +
>  drivers/iio/light/Makefile                    |   1 +
>  drivers/iio/light/ltrf216a.c                  | 537 ++++++++++++++++++
>  4 files changed, 598 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/light/liteon,ltrf216a.yaml
>  create mode 100644 drivers/iio/light/ltrf216a.c
>