linux-kernel - Re: [PATCH v4 0/9] Improve MCP3911 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220731174112.072345e3@jic23-huawei>
Date:   Sun, 31 Jul 2022 17:41:12 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Marcus Folkesson <marcus.folkesson@...il.com>
Cc:     Kent Gustavsson <kent@...oris.se>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 0/9] Improve MCP3911 driver

On Fri, 22 Jul 2022 15:07:17 +0200
Marcus Folkesson <marcus.folkesson@...il.com> wrote:

> Hi,
> 
> This patch series intend to fix bugs and improve functionality of the
> MCP3911 driver.
> The main features added are
> - Support for buffers
> - Interrupt driven readings
> - Support for oversampling ratio
> - Support for set scale values (Gain)
> 
> Among the bug fixes, there are changes in the formula for calculate raw
> value and a fix for mismatch in the devicetree property.
> 
> Another general improvement for the driver is to use managed resources
> for all allocated resources.
> 
Hi Marcus,

The first 3 fixes look good to me.  Do you want me to pick those up to
go in after rc1 via my togreg-fixes branch?  The side effect of doing
that is it'll be a little while before they are upstream in the branch
I'll want to pick the rest of the series on top of.

So it's a trade off between getting fixes in as soon as possible and
slowing down other improvements a little.

Jonathan

> General changes for the series:
> 
> v3:
> - Drop Phase patch
> - Add Fixes tags for those patches that are fixes
> - Move Fixes patches to the beginning of the patchset
> 
> v4:
> - Split up devm-cleanup functions 
> - Cosmetic cleanups
> - Add
>     select IIO_BUFFER
>     select IIO_TRIGGERED_BUFFER
>     To Kconfig
> - Add .endianness = IIO_BE
> 
> 
> Best regards,
> Marcus Folkesson
> 
> 
>