linux-kernel - [thermal:thermal/next 28/36] drivers/thermal/thermal_of.c:689:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before goto around lines 692. (fwd)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.22.394.2207311935070.2877@hadrien>
Date:   Sun, 31 Jul 2022 19:36:09 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...ia.fr>
To:     Daniel Lezcano <daniel.lezcano@...exp.org>
cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [thermal:thermal/next 28/36] drivers/thermal/thermal_of.c:689:1-23:
 WARNING: Function "for_each_child_of_node" should have of_node_put() before
 goto around lines 692. (fwd)

I didn't receive a code snippet with this message, but it may be worth
checkin whether there is a missing of_node_put.

julia

---------- Forwarded message ----------
Date: Sun, 31 Jul 2022 10:35:03 +0800
From: kernel test robot <lkp@...el.com>
To: kbuild@...ts.01.org
Cc: lkp@...el.com, Julia Lawall <julia.lawall@...6.fr>
Subject: [thermal:thermal/next 28/36] drivers/thermal/thermal_of.c:689:1-23:
    WARNING: Function "for_each_child_of_node" should have of_node_put() before
    goto around lines 692.

CC: kbuild-all@...ts.01.org
BCC: lkp@...el.com
CC: linux-kernel@...r.kernel.org
TO: Daniel Lezcano <daniel.lezcano@...exp.org>

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git thermal/next
head:   d0c75fa2c17f082b32a5f26ff40bf378b12952de
commit: a3193edcbdf9a8ae73b6e1f2da96e920582c1849 [28/36] thermal/of: Replace device node match with device node search
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago
config: nios2-randconfig-c033-20220729 (https://download.01.org/0day-ci/archive/20220731/202207311043.WDsouQI6-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>
Reported-by: Julia Lawall <julia.lawall@...6.fr>

cocci warnings: (new ones prefixed by >>)
>> drivers/thermal/thermal_of.c:689:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before goto around lines 692.

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp