linux-kernel - Re: [PATCH -next] RDMA/mlx5: unchecked return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YuY+iGeu+jRJFGki@unreal>
Date:   Sun, 31 Jul 2022 11:34:16 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Sebin Sebastian <mailmesebin00@...il.com>
Cc:     Jason Gunthorpe <jgg@...pe.ca>, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] RDMA/mlx5: unchecked return value

On Sat, Jul 30, 2022 at 04:02:42PM +0530, Sebin Sebastian wrote:
> Unchecked return value warning as reported by Coverity static analyzer
> tool. check the return value of mlx5_ib_ft_type_to_namespace().
> 
> Signed-off-by: Sebin Sebastian <mailmesebin00@...il.com>
> ---
>  drivers/infiniband/hw/mlx5/fs.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Thanks, I had similar patch in my internal queue.
https://lore.kernel.org/linux-rdma/7b9ceda217d9368a51dc47a46b769bad4af9ac92.1659256069.git.leonro@nvidia.com/T/#u

> 
> diff --git a/drivers/infiniband/hw/mlx5/fs.c b/drivers/infiniband/hw/mlx5/fs.c
> index 691d00c89f33..617e0e9c0c8e 100644
> --- a/drivers/infiniband/hw/mlx5/fs.c
> +++ b/drivers/infiniband/hw/mlx5/fs.c
> @@ -2079,9 +2079,12 @@ static int mlx5_ib_matcher_ns(struct uverbs_attr_bundle *attrs,
>  			return err;
>  
>  		if (flags) {
> -			mlx5_ib_ft_type_to_namespace(
> +			err = mlx5_ib_ft_type_to_namespace(
>  				MLX5_IB_UAPI_FLOW_TABLE_TYPE_NIC_TX,
>  				&obj->ns_type);
> +			if (err)
> +				return err;
> +
>  			return 0;
>  		}
>  	}
> -- 
> 2.34.1
>