linux-kernel - Re: [PATCH] drm/i915/userptr: remove redundation assignment to variable ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 1 Aug 2022 10:11:53 -0700
From:   Niranjana Vishwanathapura <niranjana.vishwanathapura@...el.com>
To:     Colin Ian King <colin.i.king@...il.com>
Cc:     Jani Nikula <jani.nikula@...ux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@...el.com>,
        Tvrtko Ursulin <tvrtko.ursulin@...ux.intel.com>,
        David Airlie <airlied@...ux.ie>,
        intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/i915/userptr: remove redundation assignment to
 variable ret

On Sat, Jul 30, 2022 at 01:23:42PM +0100, Colin Ian King wrote:
>Variable ret is assigned a value that is never read; it is either
>being re-assigned during the following while-loop or after the loop.
>The assignmnt is redundant and can be removed.
>
>Cleans up clang scan build warning:
>drivers/gpu/drm/i915/gem/i915_gem_userptr.c:295:11: warning: Although
>the value stored to 'ret' is used in the enclosing expression, the
>value is never actually read from 'ret' [deadcode.DeadStores]
>
>Signed-off-by: Colin Ian King <colin.i.king@...il.com>
>---
> drivers/gpu/drm/i915/gem/i915_gem_userptr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/i915/gem/i915_gem_userptr.c b/drivers/gpu/drm/i915/gem/i915_gem_userptr.c
>index 8423df021b71..075aef875a07 100644
>--- a/drivers/gpu/drm/i915/gem/i915_gem_userptr.c
>+++ b/drivers/gpu/drm/i915/gem/i915_gem_userptr.c
>@@ -292,7 +292,7 @@ int i915_gem_object_userptr_submit_init(struct drm_i915_gem_object *obj)
> 	if (!i915_gem_object_is_readonly(obj))
> 		gup_flags |= FOLL_WRITE;
>
>-	pinned = ret = 0;
>+	pinned = 0;
> 	while (pinned < num_pages) {
> 		ret = pin_user_pages_fast(obj->userptr.ptr + pinned * PAGE_SIZE,
> 					  num_pages - pinned, gup_flags,

LGTM.
Reviewed-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@...el.com>

>-- 
>2.35.3
>