linux-kernel - Re: [PATCH v4 01/17] dt-bindings: PCI: dwc: Detach common RP/EP DT bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220801173016.GA1218163-robh@kernel.org>
Date:   Mon, 1 Aug 2022 11:30:16 -0600
From:   Rob Herring <robh@...nel.org>
To:     Serge Semin <Sergey.Semin@...kalelectronics.ru>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        linux-pci@...r.kernel.org, devicetree@...r.kernel.org,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Frank Li <Frank.Li@....com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Gustavo Pimentel <gustavo.pimentel@...opsys.com>,
        Pavel Parkhomenko <Pavel.Parkhomenko@...kalelectronics.ru>,
        linux-kernel@...r.kernel.org, Jingoo Han <jingoohan1@...il.com>,
        Alexey Malahov <Alexey.Malahov@...kalelectronics.ru>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Serge Semin <fancer.lancer@...il.com>
Subject: Re: [PATCH v4 01/17] dt-bindings: PCI: dwc: Detach common RP/EP DT
 bindings

On Thu, 28 Jul 2022 17:34:11 +0300, Serge Semin wrote:
> Currently both DW PCIe Root Port and End-point DT bindings are defined as
> separate schemas. Carefully looking at them, at the hardware reference
> manuals and seeing there is a generic part of the driver used by the both
> RP and EP drivers we can greatly simplify the DW PCIe controller bindings
> by moving some of the properties into the common DT schema. It concerns
> the PERST GPIO control, number of lanes, number of iATU windows and CDM
> check properties. They will be defined in the snps,dw-pcie-common.yaml
> schema which will be referenced in the DW PCIe Root Port and End-point DT
> bindings in order to evaluate the common for both of these controllers
> properties. The rest of properties like reg{,-names}, clock{s,-names},
> reset{s,-names}, etc will be consolidate there in one of the next commits.
> 
> Signed-off-by: Serge Semin <Sergey.Semin@...kalelectronics.ru>
> 
> ---
> 
> Changelog v3:
> - This is a new patch unpinned from the next one:
>   https://lore.kernel.org/linux-pci/20220503214638.1895-2-Sergey.Semin@baikalelectronics.ru/
>   by the Rob' request. (@Rob)
> ---
>  .../bindings/pci/snps,dw-pcie-common.yaml     | 76 +++++++++++++++++++
>  .../bindings/pci/snps,dw-pcie-ep.yaml         | 31 +-------
>  .../devicetree/bindings/pci/snps,dw-pcie.yaml | 33 +-------
>  3 files changed, 78 insertions(+), 62 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml
> 

Reviewed-by: Rob Herring <robh@...nel.org>