linux-kernel - Re: [PATCH v4] ufs: core: print UFSHCD capabilities in controller's sysfs node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1ca16b27-21e5-3537-400a-25cdae52396e@acm.org>
Date:   Mon, 1 Aug 2022 10:48:45 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Daniil Lunev <dlunev@...omium.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Alim Akhtar <alim.akhtar@...sung.com>,
        Avri Altman <avri.altman@....com>,
        Bean Huo <beanhuo@...ron.com>, Can Guo <cang@...eaurora.org>,
        Daejun Park <daejun7.park@...sung.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        Sohaib Mohamed <sohaib.amhmd@...il.com>,
        Stanley Chu <stanley.chu@...iatek.com>,
        linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org
Subject: Re: [PATCH v4] ufs: core: print UFSHCD capabilities in controller's
 sysfs node

On 7/28/22 22:13, Daniil Lunev wrote:
> Allows userspace to check if Clock Scaling, Write Booster functionality
> status.

The above sentence is not complete. Did you perhaps want to write "are 
supported by the host controller" instead of "status"?

> +What:		/sys/bus/platform/drivers/ufshcd/*/capabilities/clock_scaling
> +What:		/sys/bus/platform/devices/*.ufs/capabilities/clock_scaling
> +Date:		July 2022
> +Contact:	Daniil Lunev <dlunev@...omium.org>
> +Description:	Indicates status of clock scaling.
> +
> +		== ============================
> +		0  Clock scaling is not enabled.
> +		1  Clock scaling is enabled.
> +		== ============================
> +
> +		The file is read only.

I don't think the above documentation is correct. My understanding is 
that the UFSHCD_CAP_CLK_SCALING flag indicates whether or not the host 
controller supports clock scaling. It does not indicate whether or not 
clock scaling is enabled.

> +What:		/sys/bus/platform/drivers/ufshcd/*/capabilities/write_booster
> +What:		/sys/bus/platform/devices/*.ufs/capabilities/write_booster
> +Date:		July 2022
> +Contact:	Daniil Lunev <dlunev@...omium.org>
> +Description:	Indicates status of Write Booster.
> +
> +		== ============================
> +		0  Write Booster can not be enabled.
> +		1  Write Booster can be enabled.
> +		== ============================
> +
> +		The file is read only.

Please change "can not / can be enabled" into "is not supported by the 
host controller / is supported by the host controller".

Thanks,

Bart.