linux-kernel - Re: [PATCH v3 3/8] tools include: add dis-asm-compat.h to handle version differences

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220801181025.xcgiui7hmp3rfmyr@awork3.anarazel.de>
Date:   Mon, 1 Aug 2022 11:10:25 -0700
From:   Andres Freund <andres@...razel.de>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Ben Hutchings <benh@...ian.org>, bpf@...r.kernel.org,
        linux-kernel@...r.kernel.org, Alexei Starovoitov <ast@...nel.org>,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Sedat Dilek <sedat.dilek@...il.com>,
        Quentin Monnet <quentin@...valent.com>
Subject: Re: [PATCH v3 3/8] tools include: add dis-asm-compat.h to handle
 version differences

Hi,

On 2022-08-01 15:05:00 -0300, Arnaldo Carvalho de Melo wrote:
> Em Sun, Jul 31, 2022 at 06:38:29PM -0700, Andres Freund escreveu:
> > binutils changed the signature of init_disassemble_info(), which now causes
> > compilation failures for tools/{perf,bpf}, e.g. on debian unstable.
> > Relevant binutils commit:
> > https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=60a3da00bd5407f07
> > 
> > This commit introduces a wrapper for init_disassemble_info(), to avoid
> > spreading #ifdef DISASM_INIT_STYLED to a bunch of places. Subsequent
> > commits will use it to fix the build failures.
> > 
> > It likely is worth adding a wrapper for disassember(), to avoid the already
> > existing DISASM_FOUR_ARGS_SIGNATURE ifdefery.
> > 
> > Cc: Alexei Starovoitov <ast@...nel.org>
> > Cc: Arnaldo Carvalho de Melo <acme@...hat.com>
> > Cc: Sedat Dilek <sedat.dilek@...il.com>
> > Cc: Quentin Monnet <quentin@...valent.com>
> > Cc: Ben Hutchings <benh@...ian.org>
> > Link: http://lore.kernel.org/lkml/20220622181918.ykrs5rsnmx3og4sv@alap3.anarazel.de
> > Signed-off-by: Andres Freund <andres@...razel.de>
> > Signed-off-by: Ben Hutchings <benh@...ian.org>
> 
> So, who is the author of this patch? Ben? b4 complained about it:

I squashed a fixup of Ben into my patch (moving the include in annotate.c into
the HAVE_LIBBFD_SUPPORT section). I don't know what the proper procedure is
for that - I'd asked in
https://lore.kernel.org/20220715191641.go6xbmhic3kafcsc@awork3.anarazel.de


> NOTE: some trailers ignored due to from/email mismatches:
>     ! Trailer: Signed-off-by: Ben Hutchings <benh@...ian.org>
>      Msg From: Andres Freund <andres@...razel.de>
> NOTE: Rerun with -S to apply them anyway
> 
> If it is Ben, then we would need a:
> 
> From: Ben Hutchings <benh@...ian.org>
> 
> At the beginning of the patch, right?

I don't know, I interact with the kernel processes too rarely...

Greetings,

Andres Freund