linux-kernel - RE:(2) [PATCH v5 2/6] scsi: ufs: wb: Change functions name and modify parameter name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 01 Aug 2022 12:45:38 +0900
From:   Jinyoung CHOI <j-young.choi@...sung.com>
To:     Bart Van Assche <bvanassche@....org>,
        ALIM AKHTAR <alim.akhtar@...sung.com>,
        "avri.altman@....com" <avri.altman@....com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "beanhuo@...ron.com" <beanhuo@...ron.com>,
        "adrian.hunter@...el.com" <adrian.hunter@...el.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE:(2) [PATCH v5 2/6] scsi: ufs: wb: Change functions name and
 modify parameter name

>On 7/28/22 21:54, Jinyoung CHOI wrote:
>> -static inline void ufshcd_wb_config(struct ufs_hba *hba)
>> +static void ufshcd_wb_set_default_flags(struct ufs_hba *hba)
>
>It is not clear to me why the new name is considered an improvement? The 
>old name looks better to me. If you want to rename this function anyway, 
>how about ufshcd_configure_wb()?
>
>Thanks,
>
>Bart.

It is desirable to express it as configure because it sets several values.
I will change it.
Thank you for your opinion.

Kind Regards,
Jinyoung.