lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 1 Aug 2022 15:17:24 -0500 From: Bjorn Helgaas <helgaas@...nel.org> To: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org> Cc: Serge Semin <Sergey.Semin@...kalelectronics.ru>, Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>, Lorenzo Pieralisi <lorenzo.pieralisi@....com>, Jingoo Han <jingoohan1@...il.com>, Gustavo Pimentel <gustavo.pimentel@...opsys.com>, Lorenzo Pieralisi <lpieralisi@...nel.org>, Krzysztof WilczyĆski <kw@...ux.com>, Rahul Tanwar <rtanwar@...linear.com>, Serge Semin <fancer.lancer@...il.com>, Alexey Malahov <Alexey.Malahov@...kalelectronics.ru>, Pavel Parkhomenko <Pavel.Parkhomenko@...kalelectronics.ru>, Frank Li <Frank.Li@....com>, Rob Herring <robh+dt@...nel.org>, linux-pci@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH RESEND v4 14/15] PCI: dwc: Check iATU in/outbound ranges setup methods status On Mon, Aug 01, 2022 at 07:24:57PM +0530, Manivannan Sadhasivam wrote: > On Fri, Jun 24, 2022 at 05:39:46PM +0300, Serge Semin wrote: > > Let's make the DWC PCIe RC/EP safer and more verbose for the invalid or > > failed inbound and outbound iATU windows setups. Needless to say that > > silently ignoring iATU regions setup errors may cause unpredictable > > errors. For instance if for some reason a cfg or IO window fails to be > > activated, then any CFG/IO requested won't reach target PCIe devices and > > the corresponding accessors will return platform-specific random values. > > > > First of all we need to convert dw_pcie_ep_outbound_atu() method to check > > whether the specified outbound iATU range is successfully setup. That > > method is called by the pci_epc_ops.map_addr callback. Thus we'll make the > > EP-specific CPU->PCIe memory mappings saver. > > > > Secondly since the iATU outbound range programming method now returns the > > operation status, it will be handy to take that status into account in the > > pci_ops.{map_bus,read,write} methods. Thus any failed mapping will be > > immediately noticeable by the PCIe CFG operations requesters. > > > > Finally we need to convert the dw_pcie_setup_rc() method to returning the > > operation status, since the iATU outbound ranges setup procedure may now > > fail. It will be especially handy in case if the DW PCIe RC DT-node has > > invalid/unsupported (dma-)ranges property. Note since the suggested > > modification causes having too wide code indentation, it is reasonable > > from maintainability and readability points of view to move the outbound > > ranges setup procedure in the separate function. > > > > Signed-off-by: Serge Semin <Sergey.Semin@...kalelectronics.ru> > > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org> Thank you very much for all your reviews, Manivannan! I added your reviewed-by to the appropriate commits.
Powered by blists - more mailing lists