linux-kernel - Re: [PATCH] dt-bindings: crypto: ti,sa2ul: drop dma-coherent property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1896bceb-2c0d-4c87-4fb6-1e418bf5cef1@ti.com>
Date:   Mon, 1 Aug 2022 10:20:40 +0530
From:   Jayesh Choudhary <j-choudhary@...com>
To:     Rob Herring <robh@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>
CC:     <linux-kernel@...r.kernel.org>, <linux-crypto@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <vigneshr@...com>,
        <davem@...emloft.net>, <robh+dt@...nel.org>,
        <herbert@...dor.apana.org.au>, <j-keerthy@...com>
Subject: Re: [PATCH] dt-bindings: crypto: ti,sa2ul: drop dma-coherent property


Rob,

On 11/07/22 14:36, Jayesh Choudhary wrote:
> Hi Rob,
> 
> On 09/07/22 3:02 am, Rob Herring wrote:
>> On Thu, 07 Jul 2022 16:37:56 +0530, Jayesh Choudhary wrote:
>>> crypto driver itself is not dma-coherent. It is the dmaengine
>>> that moves data and the buffers are to be mapped to the
>>> dmaengine provider. So this property should be dropped.
>>>
>>> Fixes: 2ce9a7299bf6 ('dt-bindings: crypto: Add TI SA2UL crypto accelerator documentation')
>>> Signed-off-by: Jayesh Choudhary <j-choudhary@...com>
>>> ---
>>>   .../devicetree/bindings/crypto/ti,sa2ul.yaml        | 13 -------------
>>>   1 file changed, 13 deletions(-)
>>>
>>
>> Running 'make dtbs_check' with the schema in this patch gives the
>> following warnings. Consider if they are expected or the schema is
>> incorrect. These may not be new warnings.
>>
>> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
>> This will change in the future.
>>
>> Full log is available here: https://patchwork.ozlabs.org/patch/
>>
>>
>> crypto@...0000: 'dma-coherent' does not match any of the regexes: '^rng@[a-f0-9]+$', 'pinctrl-[0-9]+'
>> 	arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic.dtb
>> 	arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic-pg2.dtb
>> 	arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dtb
>> 	arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-pg2.dtb
>> 	arch/arm64/boot/dts/ti/k3-am654-base-board.dtb
>> 	arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb
>> 	arch/arm64/boot/dts/ti/k3-j721e-sk.dtb
>>
> 
> These warnings are expected. dt-node fixes need to be there.
> I will send the dt-node fixes once this patch gets in due to
> dependency. Or should I proceed any other way?
> 
> Thanks,
> Jayesh



This patch is ACKed and there are no other comments.
Can this patch be merged so that I can move forward with dt node
fixes or do you have any other comments on this?

Regards,
Jayesh