linux-kernel - [PATCH linux-next] bcache: writeback:Remove the redundant 'flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20220801021842.1594130-1-ye.xingchen@zte.com.cn>
Date:   Mon,  1 Aug 2022 02:18:42 +0000
From:   cgel.zte@...il.com
To:     linux-kernel@...r.kernel.org
Cc:     linux-bcache@...r.kernel.org, ye xingchen <ye.xingchen@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: [PATCH linux-next] bcache: writeback:Remove the redundant 'flush_workqueue()' calls

From: ye xingchen <ye.xingchen@....com.cn>

calls 'destroy_workqueue()' already drains the queue before destroying it,
so there is no need to flush it explicitly.So,remove the redundant
'flush_workqueue()' calls.

Reported-by: Zeal Robot <zealci@....com.cn>
Signed-off-by: ye xingchen <ye.xingchen@....com.cn>
---
 drivers/md/bcache/writeback.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/md/bcache/writeback.c b/drivers/md/bcache/writeback.c
index 3f0ff3aab6f2..fd48a09e6096 100644
--- a/drivers/md/bcache/writeback.c
+++ b/drivers/md/bcache/writeback.c
@@ -802,7 +802,6 @@ static int bch_writeback_thread(void *arg)
 	}
 
 	if (dc->writeback_write_wq) {
-		flush_workqueue(dc->writeback_write_wq);
 		destroy_workqueue(dc->writeback_write_wq);
 	}
 	cached_dev_put(dc);
-- 
2.25.1