linux-kernel - Re: [PATCH -next] panic: Add register_panic_notifier and unregister_panic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2d4fa03a-f460-d995-88e8-7f0e58e557bd@igalia.com>
Date:   Mon, 1 Aug 2022 09:11:46 -0300
From:   "Guilherme G. Piccoli" <gpiccoli@...lia.com>
To:     Xu Qiang <xuqiang36@...wei.com>, pmladek@...e.com,
        akpm@...ux-foundation.org, elver@...gle.com, mcgrof@...nel.org,
        tangmeng@...ontech.com, yangtiezhu@...ngson.cn,
        john.ogness@...utronix.de, bigeasy@...utronix.de
Cc:     linux-kernel@...r.kernel.org, guohanjun@...wei.com,
        weiyongjun1@...wei.com
Subject: Re: [PATCH -next] panic: Add register_panic_notifier and
 unregister_panic_notifier

On 01/08/2022 07:05, Xu Qiang wrote:
> Add two methods to manipulate panic_notifier_list and export them.
> Subsequently, panic_notifier_list is changed to static variable.
> 
> Signed-off-by: Xu Qiang <xuqiang36@...wei.com>

Hi Xu Qiang, first of all, thanks for your patch!
I'd like to mention 2 things about it:

(a) As-is, there's no much use for it - I mean, you're adding a helper
but you didn't change the uses of such notifier list addition (and there
are plenty of them). Are you intend to change it, or just use the new
API in new calls?

(b) Even more important: we are working in a panic notifier refactor
[0], and that'll add new lists. I'm still working on that, plan to
submit (relatively) soon. Maybe worth to wait it, if this one is not urgent?

Cheers,

Guilherme

[0]
https://lore.kernel.org/lkml/20220427224924.592546-1-gpiccoli@igalia.com/