linux-kernel - Re: [PATCH 1/2 v2] lib/vsprintf: Remove static_branch_likely() from __ptr_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YufKL+3AKhLmlAcK@linutronix.de>
Date:   Mon, 1 Aug 2022 14:42:23 +0200
From:   Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:     "Jason A. Donenfeld" <Jason@...c4.com>
Cc:     linux-kernel@...r.kernel.org,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        John Ogness <john.ogness@...utronix.de>,
        Mike Galbraith <efault@....de>, Petr Mladek <pmladek@...e.com>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Theodore Ts'o <tytso@....edu>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 1/2 v2] lib/vsprintf: Remove static_branch_likely() from
 __ptr_to_hashval().

On 2022-08-01 14:13:36 [+0200], Jason A. Donenfeld wrote:
> Also,
> 
> On Fri, Jul 29, 2022 at 05:47:15PM +0200, Sebastian Andrzej Siewior wrote:
> >  		if (!filled) {
> >  			get_random_bytes(&ptr_key, sizeof(ptr_key));
> > -			queue_work(system_unbound_wq, &enable_ptr_key_work);
> > +			/* Pairs with smp_rmb() before reading ptr_key. */
> > +			smp_wmb();
> > +			WRITE_ONCE(filled_random_ptr_key, true);
> >  			filled = true;
> 
> Also, should `filled` be changed there?

you change `filled` as in read_mostly?

> Jason

Sebastian