linux-kernel - Re: [PATCH] hfsplus: Convert kmap() to kmap_local

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2117828.irdbgypaU6@opensuse>
Date:   Mon, 01 Aug 2022 14:56:42 +0200
From:   "Fabio M. De Francesco" <fmdefrancesco@...il.com>
To:     Matthew Wilcox <willy@...radead.org>,
        Viacheslav Dubeyko <slava@...eyko.com>,
        Ira Weiny <ira.weiny@...el.com>
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hfsplus: Convert kmap() to kmap_local_page() in bitmap.c

On martedì 26 luglio 2022 20:40:29 CEST Viacheslav Dubeyko wrote:
> 
> > On Jul 25, 2022, at 10:54 AM, Matthew Wilcox <willy@...radead.org> 
wrote:
> > 
> > On Mon, Jul 25, 2022 at 10:17:13AM -0700, Viacheslav Dubeyko wrote:
> >> Looks good. Maybe, it makes sense to combine all kmap() related 
modifications in HFS+ into
> >> one patchset?
> > 
> > For bisection, I'd think it best to leave them separate?
> 
> I am OK with any way. My point that it will be good to have patchset to 
see all modified places together, from logical point of view. Even if we 
have some issue with kmap() change on kmap_local_page(), then, as far as I 
can see, the root of issue should be kmap_local_page() but not HFS+ code. 
Oppositely, if it’s some undiscovered HFS+ issue, then again 
kmap_local_page() changes nothing. But I am OK if it is separate patches 
too.
> 
> Thanks,
> Slava.
> 
And I am OK with sending a patchset :-)

I'm sorry because, while working on the last conversions for HFS+ in 
btree.c, I just noticed that I had overlooked one other kmap() call site in 
bitmap.c.

Therefore, I'd like to ask to drop this patch and I'll also ask to drop the 
patch to bnode.c in the related thread. 

When done, I'll send a series of three patches, one per file (bnode.c, 
bitmap.c, btree.c).

Thanks,

Fabio