linux-kernel - drivers/net/ethernet/engleder/tsnep_main.c:1254:34: warning: 'tsnep_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 1 Aug 2022 21:53:25 +0800
From:   kernel test robot <lkp@...el.com>
To:     Gerhard Engleder <gerhard@...leder-embedded.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: drivers/net/ethernet/engleder/tsnep_main.c:1254:34: warning:
 'tsnep_of_match' defined but not used

Hi Gerhard,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   3d7cb6b04c3f3115719235cc6866b10326de34cd
commit: 403f69bbdbadb2e601f725be2d00b4ccc7b61c9d tsnep: Add TSN endpoint Ethernet MAC driver
date:   8 months ago
config: x86_64-randconfig-r012-20220801 (https://download.01.org/0day-ci/archive/20220801/202208012104.Xlxe8EYV-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=403f69bbdbadb2e601f725be2d00b4ccc7b61c9d
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 403f69bbdbadb2e601f725be2d00b4ccc7b61c9d
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/net/ethernet/engleder/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/engleder/tsnep_main.c: In function 'tsnep_netdev_set_mac_address':
   drivers/net/ethernet/engleder/tsnep_main.c:1007:31: warning: passing argument 1 of 'ether_addr_copy' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
    1007 |         ether_addr_copy(netdev->dev_addr, sock_addr->sa_data);
         |                         ~~~~~~^~~~~~~~~~
   In file included from drivers/net/ethernet/engleder/tsnep.h:11,
                    from drivers/net/ethernet/engleder/tsnep_main.c:18:
   include/linux/etherdevice.h:295:40: note: expected 'u8 *' {aka 'unsigned char *'} but argument is of type 'const unsigned char *'
     295 | static inline void ether_addr_copy(u8 *dst, const u8 *src)
         |                                    ~~~~^~~
   drivers/net/ethernet/engleder/tsnep_main.c: In function 'tsnep_mac_init':
   drivers/net/ethernet/engleder/tsnep_main.c:1054:40: warning: passing argument 1 of 'ether_addr_copy' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
    1054 |         ether_addr_copy(adapter->netdev->dev_addr, adapter->mac_address);
         |                         ~~~~~~~~~~~~~~~^~~~~~~~~~
   In file included from drivers/net/ethernet/engleder/tsnep.h:11,
                    from drivers/net/ethernet/engleder/tsnep_main.c:18:
   include/linux/etherdevice.h:295:40: note: expected 'u8 *' {aka 'unsigned char *'} but argument is of type 'const unsigned char *'
     295 | static inline void ether_addr_copy(u8 *dst, const u8 *src)
         |                                    ~~~~^~~
   At top level:
>> drivers/net/ethernet/engleder/tsnep_main.c:1254:34: warning: 'tsnep_of_match' defined but not used [-Wunused-const-variable=]
    1254 | static const struct of_device_id tsnep_of_match[] = {
         |                                  ^~~~~~~~~~~~~~


vim +/tsnep_of_match +1254 drivers/net/ethernet/engleder/tsnep_main.c

  1253	
> 1254	static const struct of_device_id tsnep_of_match[] = {
  1255		{ .compatible = "engleder,tsnep", },
  1256	{ },
  1257	};
  1258	MODULE_DEVICE_TABLE(of, tsnep_of_match);
  1259	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp