linux-kernel - Re: [PATCH -next] panic: Add register_panic_notifier and unregister_panic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3509f2c9-2ab9-c1f5-8c27-ab8be771360d@igalia.com>
Date:   Mon, 1 Aug 2022 11:25:34 -0300
From:   "Guilherme G. Piccoli" <gpiccoli@...lia.com>
To:     "xuqiang (M)" <xuqiang36@...wei.com>,
        "pmladek@...e.com" <pmladek@...e.com>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "elver@...gle.com" <elver@...gle.com>,
        "mcgrof@...nel.org" <mcgrof@...nel.org>,
        "tangmeng@...ontech.com" <tangmeng@...ontech.com>,
        "yangtiezhu@...ngson.cn" <yangtiezhu@...ngson.cn>,
        "john.ogness@...utronix.de" <john.ogness@...utronix.de>,
        "bigeasy@...utronix.de" <bigeasy@...utronix.de>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Guohanjun (Hanjun Guo)" <guohanjun@...wei.com>,
        "weiyongjun (A)" <weiyongjun1@...wei.com>
Subject: Re: [PATCH -next] panic: Add register_panic_notifier and
 unregister_panic_notifier

On 01/08/2022 10:58, xuqiang (M) wrote:
> 在 2022/8/1 20:12, Guilherme G. Piccoli 写道:
>> On 01/08/2022 07:05, Xu Qiang wrote:
>>> Add two methods to manipulate panic_notifier_list and export them.
>>> Subsequently, panic_notifier_list is changed to static variable.
>>>
>>> Signed-off-by: Xu Qiang <xuqiang36@...wei.com>
>> Hi Xu Qiang, first of all, thanks for your patch!
>> I'd like to mention 2 things about it:
>>
>> (a) As-is, there's no much use for it - I mean, you're adding a helper
>> but you didn't change the uses of such notifier list addition (and there
>> are plenty of them). Are you intend to change it, or just use the new
>> API in new calls?
> After this patch comes in, I will replace all the old interfaces with
> the new ones.
>>
>> (b) Even more important: we are working in a panic notifier refactor
>> [0], and that'll add new lists. I'm still working on that, plan to
>> submit (relatively) soon. Maybe worth to wait it, if this one is not urgent?
> I can wait for your patch to be incorporated before submitting it.

Great, thanks Xu! I'll include you in the CC list of the V2 =)