linux-kernel - Re: [PATCH] dt-bindings: remove the dead code in cmd_mk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220801151216.GA1026724-robh@kernel.org>
Date:   Mon, 1 Aug 2022 09:12:16 -0600
From:   Rob Herring <robh@...nel.org>
To:     Masahiro Yamada <masahiroy@...nel.org>
Cc:     Frank Rowand <frowand.list@...il.com>, devicetree@...r.kernel.org,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Nathan Chancellor <nathan@...nel.org>,
        Sam Protsenko <semen.protsenko@...aro.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: remove the dead code in cmd_mk_schema

On Fri, Jul 29, 2022 at 02:21:12PM +0900, Masahiro Yamada wrote:
> Since commit 2783a7f56f99 ("dt-bindings: kbuild: Pass DT_SCHEMA_FILES to
> dt-validate"), the processed schema takes all the YAML files.
> 
> Remove the dead code.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> ---
> 
>  Documentation/devicetree/bindings/Makefile | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)

I also sent out a similar patch[1].

> 
> diff --git a/Documentation/devicetree/bindings/Makefile b/Documentation/devicetree/bindings/Makefile
> index c9953f86b19d..223df2a023fd 100644
> --- a/Documentation/devicetree/bindings/Makefile
> +++ b/Documentation/devicetree/bindings/Makefile
> @@ -42,10 +42,8 @@ quiet_cmd_chk_bindings = CHKDT   $@
>  
>  quiet_cmd_mk_schema = SCHEMA  $@
>        cmd_mk_schema = f=$$(mktemp) ; \
> -                      $(if $(DT_MK_SCHEMA_FLAGS), \
> -                           printf '%s\n' $(real-prereqs), \
> -                           $(find_all_cmd)) > $$f ; \
> -                      $(DT_MK_SCHEMA) -j $(DT_MK_SCHEMA_FLAGS) @$$f > $@ ; \
> +		      $(find_all_cmd) > $$f ; \
> +		      $(DT_MK_SCHEMA) -j @$$f > $@ ; \

I want to keep DT_MK_SCHEMA_FLAGS because I'm working on a new optional 
flag to pass.

Rob

[1] https://lore.kernel.org/all/20220727211100.3249417-1-robh@kernel.org/