linux-kernel - Re: [Freedreno] [PATCH 2/5] clk: qcom: Allow custom reset ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b3c5dec2-6d73-4d7a-8a2f-194672f2c675@quicinc.com>
Date:   Mon, 1 Aug 2022 20:50:29 +0530
From:   Akhil P Oommen <quic_akhilpo@...cinc.com>
To:     kernel test robot <lkp@...el.com>,
        freedreno <freedreno@...ts.freedesktop.org>,
        <dri-devel@...ts.freedesktop.org>, <linux-arm-msm@...r.kernel.org>,
        Rob Clark <robdclark@...il.com>,
        "Bjorn Andersson" <bjorn.andersson@...aro.org>,
        Stephen Boyd <swboyd@...omium.org>
CC:     <kbuild-all@...ts.01.org>,
        Michael Turquette <mturquette@...libre.com>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Douglas Anderson <dianders@...omium.org>,
        <linux-kernel@...r.kernel.org>, Andy Gross <agross@...nel.org>,
        <linux-clk@...r.kernel.org>
Subject: Re: [Freedreno] [PATCH 2/5] clk: qcom: Allow custom reset ops

On 7/30/2022 6:40 PM, kernel test robot wrote:
> Hi Akhil,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on clk/clk-next]
> [also build test WARNING on robh/for-next drm-misc/drm-misc-next drm-tip/drm-tip linus/master v5.19-rc8 next-20220728]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url:    https://github.com/intel-lab-lkp/linux/commits/Akhil-P-Oommen/clk-qcom-Support-gdsc-collapse-polling-using-reset-inteface/20220730-171922
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
> config: ia64-randconfig-r031-20220729 (https://download.01.org/0day-ci/archive/20220730/202207302137.mPbHPaHz-lkp@intel.com/config)
> compiler: ia64-linux-gcc (GCC) 12.1.0
> reproduce (this is a W=1 build):
>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>          chmod +x ~/bin/make.cross
>          # https://github.com/intel-lab-lkp/linux/commit/971a03493e9854ff4a227ee4d80b533997959891
>          git remote add linux-review https://github.com/intel-lab-lkp/linux
>          git fetch --no-tags linux-review Akhil-P-Oommen/clk-qcom-Support-gdsc-collapse-polling-using-reset-inteface/20220730-171922
>          git checkout 971a03493e9854ff4a227ee4d80b533997959891
>          # save the config file
>          mkdir build_dir && cp config build_dir/.config
>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/clk/qcom/
>
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@...el.com>
>
> All warnings (new ones prefixed by >>):
>
>     drivers/clk/qcom/reset.c: In function 'qcom_reset':
>>> drivers/clk/qcom/reset.c:17:9: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
>        17 |         const struct qcom_reset_map *map = &rst->reset_map[id];
>           |         ^~~~~
>
>
> vim +17 drivers/clk/qcom/reset.c
>
>      13	
>      14	static int qcom_reset(struct reset_controller_dev *rcdev, unsigned long id)
>      15	{
>      16		struct qcom_reset_controller *rst = to_qcom_reset_controller(rcdev);
>    > 17		const struct qcom_reset_map *map = &rst->reset_map[id];
>      18	
>      19		if (map->op)
>      20			return map->op(map);
>      21	
>      22		rcdev->ops->assert(rcdev, id);
>      23		udelay(1);
>      24		rcdev->ops->deassert(rcdev, id);
>      25		return 0;
>      26	}
>      27	
>
Will fix this and send another version of this patch. Please let me know 
if there is any feedback to the whole series.

-Akhil.