linux-kernel - Re: [PATCH 1/5] dt-bindings: net: Add generic Bluetooth controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 1 Aug 2022 09:23:38 -0600
From:   Rob Herring <robh@...nel.org>
To:     Sven Peter <sven@...npeter.dev>
Cc:     Marcel Holtmann <marcel@...tmann.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Hector Martin <marcan@...can.st>,
        Alyssa Rosenzweig <alyssa@...enzweig.io>,
        asahi@...ts.linux.dev, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] dt-bindings: net: Add generic Bluetooth controller

On Mon, Aug 01, 2022 at 12:36:29PM +0200, Sven Peter wrote:
> Bluetooth controllers share the common local-bd-address property.
> Add a generic YAML schema to replace bluetooth.txt for those.
> 
> Signed-off-by: Sven Peter <sven@...npeter.dev>
> ---
> I hope it's fine to list the current Bluetooth maintainers in here
> as well.
> 
>  .../bindings/net/bluetooth-controller.yaml    | 30 +++++++++++++++++++
>  .../devicetree/bindings/net/bluetooth.txt     |  6 +---
>  2 files changed, 31 insertions(+), 5 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/net/bluetooth-controller.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/bluetooth-controller.yaml b/Documentation/devicetree/bindings/net/bluetooth-controller.yaml
> new file mode 100644
> index 000000000000..0ea8a20e30f9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/bluetooth-controller.yaml
> @@ -0,0 +1,30 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/bluetooth-controller.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Bluetooth Controller Generic Binding
> +
> +maintainers:
> +  - Marcel Holtmann <marcel@...tmann.org>
> +  - Johan Hedberg <johan.hedberg@...il.com>
> +  - Luiz Augusto von Dentz <luiz.dentz@...il.com>
> +
> +properties:
> +  $nodename:
> +    pattern: "^bluetooth(@.*)?$"
> +
> +  local-bd-address:
> +    $ref: /schemas/types.yaml#/definitions/uint8-array
> +    minItems: 6
> +    maxItems: 6
> +    description:
> +      Specifies the BD address that was uniquely assigned to the Bluetooth
> +      device. Formatted with least significant byte first (little-endian), e.g.
> +      in order to assign the address 00:11:22:33:44:55 this property must have
> +      the value [55 44 33 22 11 00].
> +
> +additionalProperties: true
> +
> +...
> diff --git a/Documentation/devicetree/bindings/net/bluetooth.txt b/Documentation/devicetree/bindings/net/bluetooth.txt
> index 94797df751b8..3cb5a7b8e5ad 100644
> --- a/Documentation/devicetree/bindings/net/bluetooth.txt
> +++ b/Documentation/devicetree/bindings/net/bluetooth.txt
> @@ -1,5 +1 @@
> -The following properties are common to the Bluetooth controllers:
> -
> -- local-bd-address: array of 6 bytes, specifies the BD address that was
> -  uniquely assigned to the Bluetooth device, formatted with least significant
> -  byte first (little-endian).
> +This file has been moved to bluetooth-controller.yaml.

There's one reference to bluetooth.txt. Update it and remove this file.

Rob