linux-kernel - Re: [PATCH -next] of/fdt: declared return type does not match actual return type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220801161347.GA1112588-robh@kernel.org>
Date:   Mon, 1 Aug 2022 10:13:47 -0600
From:   Rob Herring <robh@...nel.org>
To:     Xu Qiang <xuqiang36@...wei.com>
Cc:     linux-kernel@...r.kernel.org, frowand.list@...il.com,
        weiyongjun1@...wei.com, robh+dt@...nel.org, guohanjun@...wei.com,
        devicetree@...r.kernel.org
Subject: Re: [PATCH -next] of/fdt: declared return type does not match actual
 return type

On Mon, 01 Aug 2022 12:05:06 +0000, Xu Qiang wrote:
> The commit 649cab56de8e (“of: properly check for error returned
> by fdt_get_name()”) changed the return value type from bool to int,
> but forgot to change the return value simultaneously.
> 
> populate_node was only called in unflatten_dt_nodes, and returns
> with values greater than or equal to 0 were discarded without further
> processing. Considering that return 0 usually indicates success,
> return 0 instead of return true.
> 
> Fixes: 649cab56de8e (“of: properly check for error returned by fdt_get_name()”)
> Signed-off-by: Xu Qiang <xuqiang36@...wei.com>
> ---
>  drivers/of/fdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied, thanks!