linux-kernel - Re: [PATCH] scsi: FlashPoint: remove redundant variable bm_int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dfcbacca-5b64-9c8a-cce1-6434e97563ee@gonehiking.org>
Date:   Mon, 1 Aug 2022 10:27:20 -0600
From:   Khalid Aziz <khalid@...ehiking.org>
To:     Colin Ian King <colin.i.king@...il.com>,
        "James E . J . Bottomley" <jejb@...ux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: FlashPoint: remove redundant variable bm_int_st

On 7/30/22 06:37, Colin Ian King wrote:
> The variable bm_int_st is assigned a value but it is never read. The
> variable and the assignment are redundant and can be removed.
> 
> Cleans up clang scan build warning:
> drivers/scsi/FlashPoint.c:1726:7: warning: Although the value stored
> to 'bm_int_st' is used in the enclosing expression, the value is never
> actually read from 'bm_int_st' [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>   drivers/scsi/FlashPoint.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

Acked-by: Khalid Aziz <khalid@...ehiking.org>


> 
> diff --git a/drivers/scsi/FlashPoint.c b/drivers/scsi/FlashPoint.c
> index 90253208a72f..3d9c56ac8224 100644
> --- a/drivers/scsi/FlashPoint.c
> +++ b/drivers/scsi/FlashPoint.c
> @@ -1712,7 +1712,7 @@ static unsigned char FlashPoint_InterruptPending(void *pCurrCard)
>   static int FlashPoint_HandleInterrupt(void *pcard)
>   {
>   	struct sccb *currSCCB;
> -	unsigned char thisCard, result, bm_status, bm_int_st;
> +	unsigned char thisCard, result, bm_status;
>   	unsigned short hp_int;
>   	unsigned char i, target;
>   	struct sccb_card *pCurrCard = pcard;
> @@ -1723,7 +1723,7 @@ static int FlashPoint_HandleInterrupt(void *pcard)
>   
>   	MDISABLE_INT(ioport);
>   
> -	if ((bm_int_st = RD_HARPOON(ioport + hp_int_status)) & EXT_STATUS_ON)
> +	if (RD_HARPOON(ioport + hp_int_status) & EXT_STATUS_ON)
>   		bm_status = RD_HARPOON(ioport + hp_ext_status) &
>   					(unsigned char)BAD_EXT_STATUS;
>   	else