linux-kernel - Re: [PATCH v2] HID: wacom: Simplify comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF8JNhKKyzqSm_52QeErUHusNEaPNjkBeJ0LKbEDNMY-dc5WnA@mail.gmail.com>
Date:   Tue, 2 Aug 2022 13:13:27 -0700
From:   Ping Cheng <pinglinux@...il.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Ping Cheng <ping.cheng@...om.com>,
        Jason Gerecke <jason.gerecke@...om.com>,
        Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-input@...r.kernel.org
Subject: Re: [PATCH v2] HID: wacom: Simplify comments

On Tue, Aug 2, 2022 at 12:45 PM Christophe JAILLET
<christophe.jaillet@...adoo.fr> wrote:
>
> Remove a left-over from commit 2874c5fd2842 ("treewide: Replace GPLv2
> boilerplate/reference with SPDX - rule 152").
> An empty comment block can be removed.
>
> While at it remove, also remove what is supposed to be the path/filename of
> the file.
> This is really low value... and wrong since commit 471d17148c8b
> ("Input: wacom - move the USB (now hid) Wacom driver in drivers/hid")
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Reviewed-by: Ping Cheng <ping.cheng@...om.com>

Cheers,
Ping

> ---
> v1 -> v2
>   - add wacom.h, wacom_wac.c, wacom_wac.h
> ---
>  drivers/hid/wacom.h     | 5 +----
>  drivers/hid/wacom_sys.c | 5 -----
>  drivers/hid/wacom_wac.c | 5 -----
>  drivers/hid/wacom_wac.h | 4 +---
>  4 files changed, 2 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/hid/wacom.h b/drivers/hid/wacom.h
> index 3f8b24a57014..4da50e19808e 100644
> --- a/drivers/hid/wacom.h
> +++ b/drivers/hid/wacom.h
> @@ -1,7 +1,5 @@
>  /* SPDX-License-Identifier: GPL-2.0-or-later */
>  /*
> - * drivers/input/tablet/wacom.h
> - *
>   *  USB Wacom tablet support
>   *
>   *  Copyright (c) 2000-2004 Vojtech Pavlik     <vojtech@....cz>
> @@ -78,10 +76,9 @@
>   *                 - integration of the Bluetooth devices
>   */
>
> -/*
> - */
>  #ifndef WACOM_H
>  #define WACOM_H
> +
>  #include <linux/kernel.h>
>  #include <linux/slab.h>
>  #include <linux/module.h>
> diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
> index 194a2e327591..21612fdae9c3 100644
> --- a/drivers/hid/wacom_sys.c
> +++ b/drivers/hid/wacom_sys.c
> @@ -1,13 +1,8 @@
>  // SPDX-License-Identifier: GPL-2.0-or-later
>  /*
> - * drivers/input/tablet/wacom_sys.c
> - *
>   *  USB Wacom tablet support - system specific code
>   */
>
> -/*
> - */
> -
>  #include "wacom_wac.h"
>  #include "wacom.h"
>  #include <linux/input/mt.h>
> diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c
> index d049239256a2..1bbd24ebacad 100644
> --- a/drivers/hid/wacom_wac.c
> +++ b/drivers/hid/wacom_wac.c
> @@ -1,13 +1,8 @@
>  // SPDX-License-Identifier: GPL-2.0-or-later
>  /*
> - * drivers/input/tablet/wacom_wac.c
> - *
>   *  USB Wacom tablet support - Wacom specific code
>   */
>
> -/*
> - */
> -
>  #include "wacom_wac.h"
>  #include "wacom.h"
>  #include <linux/input/mt.h>
> diff --git a/drivers/hid/wacom_wac.h b/drivers/hid/wacom_wac.h
> index fef1538005b5..5ca6c06d143b 100644
> --- a/drivers/hid/wacom_wac.h
> +++ b/drivers/hid/wacom_wac.h
> @@ -1,7 +1,5 @@
>  /* SPDX-License-Identifier: GPL-2.0-or-later */
> -/*
> - * drivers/input/tablet/wacom_wac.h
> - */
> +
>  #ifndef WACOM_WAC_H
>  #define WACOM_WAC_H
>
> --
> 2.34.1
>