linux-kernel - [PATCH] scsi: sun3x_esp: check the return value of ioremap() in esp_sun3x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20220802073614.3213171-1-studentxswpy@163.com>
Date:   Tue,  2 Aug 2022 15:36:14 +0800
From:   studentxswpy@....com
To:     jejb@...ux.ibm.com, martin.petersen@...cle.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Xie Shaowen <studentxswpy@....com>,
        Hacash Robot <hacashRobot@...tino.com>
Subject: [PATCH] scsi: sun3x_esp: check the return value of ioremap() in esp_sun3x_probe()

From: Xie Shaowen <studentxswpy@....com>

The function ioremap() in esp_sun3x_probe() can fail, so
its return value should be checked.

Fixes: 4bdc0d676a643 ("remove ioremap_nocache and devm_ioremap_nocache")
Reported-by: Hacash Robot <hacashRobot@...tino.com>
Signed-off-by: Xie Shaowen <studentxswpy@....com>
---
 drivers/scsi/sun3x_esp.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/scsi/sun3x_esp.c b/drivers/scsi/sun3x_esp.c
index d3489ac7ab28..cc670b50a357 100644
--- a/drivers/scsi/sun3x_esp.c
+++ b/drivers/scsi/sun3x_esp.c
@@ -199,6 +199,8 @@ static int esp_sun3x_probe(struct platform_device *dev)
 		goto fail_unmap_regs;
 
 	esp->dma_regs = ioremap(res->start, 0x10);
+	if (!esp->dma_regs)
+		goto fail_unmap_regs;
 
 	esp->command_block = dma_alloc_coherent(esp->dev, 16,
 						&esp->command_block_dma,
-- 
2.25.1