linux-kernel - [PATCH -next] drm/tegra: Add missing clk_disable_unprepare() in tegra_dc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20220802085050.27967-1-zhangzekun11@huawei.com>
Date:   Tue, 2 Aug 2022 08:50:50 +0000
From:   Zhang Zekun <zhangzekun11@...wei.com>
To:     <thierry.reding@...il.com>, <airlied@...ux.ie>, <daniel@...ll.ch>,
        <jonathanh@...dia.com>, <digetx@...il.com>
CC:     <dri-devel@...ts.freedesktop.org>, <linux-tegra@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <patchwork@...wei.com>,
        <zhangzekun11@...wei.com>, <xuqiang36@...wei.com>
Subject: [PATCH -next] drm/tegra: Add missing clk_disable_unprepare() in tegra_dc_probe()

Add the missing clk_disable_unprepare() before return from
tegra_dc_probe() in the error handling path.

Fixes: f68ba6912bd2 ("drm/tegra: dc: Link DC1 to DC0 on Tegra20")
Signed-off-by: Zhang Zekun <zhangzekun11@...wei.com>
---
 drivers/gpu/drm/tegra/dc.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c
index a2a731e8a8a3..6d29daabcc15 100644
--- a/drivers/gpu/drm/tegra/dc.c
+++ b/drivers/gpu/drm/tegra/dc.c
@@ -3205,8 +3205,10 @@ static int tegra_dc_probe(struct platform_device *pdev)
 	usleep_range(2000, 4000);
 
 	err = reset_control_assert(dc->rst);
-	if (err < 0)
+	if (err < 0) {
+		clk_disable_unprepare(dc->clk);
 		return err;
+	}
 
 	usleep_range(2000, 4000);
 
-- 
2.17.1