lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 2 Aug 2022 10:59:33 +0200 From: Hans de Goede <hdegoede@...hat.com> To: Li zeming <zeming@...china.com>, gregkh@...uxfoundation.org, sevinj.aghayeva@...il.com, fabioaiuto83@...il.com, duoming@....edu.cn, keescook@...omium.org Cc: straube.linux@...il.com, linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org Subject: Re: [PATCH] staging/rtl8723bs/core: remove inactive initialization Hi, On 8/2/22 03:25, Li zeming wrote: > The allocation address of the psta pointer variable is first performed > in the function, no initialization assignment is required, and no > invalid pointer will appear. > > Signed-off-by: Li zeming <zeming@...china.com> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@...hat.com> Regards, Hans > --- > drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c > index f2242cf2dfb4..6498fd17e1d3 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c > +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c > @@ -2521,7 +2521,7 @@ void rtw_issue_addbareq_cmd(struct adapter *padapter, struct xmit_frame *pxmitfr > { > u8 issued; > int priority; > - struct sta_info *psta = NULL; > + struct sta_info *psta; > struct ht_priv *phtpriv; > struct pkt_attrib *pattrib = &pxmitframe->attrib; > s32 bmcst = IS_MCAST(pattrib->ra);
Powered by blists - more mailing lists