linux-kernel - Re: [V2 01/11] KVM: selftests: move vm_phy_pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220802095928.ex63dnyilii5raeg@kamzik>
Date:   Tue, 2 Aug 2022 11:59:28 +0200
From:   Andrew Jones <andrew.jones@...ux.dev>
To:     Peter Gonda <pgonda@...gle.com>
Cc:     kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
        marcorr@...gle.com, seanjc@...gle.com, michael.roth@....com,
        thomas.lendacky@....com, joro@...tes.org, mizhang@...gle.com,
        pbonzini@...hat.com
Subject: Re: [V2 01/11] KVM: selftests: move vm_phy_pages_alloc() earlier in
 file

On Mon, Aug 01, 2022 at 01:10:59PM -0700, Peter Gonda wrote:
> From: Michael Roth <michael.roth@....com>
> 
> Subsequent patches will break some of this code out into file-local
> helper functions, which will be used by functions like vm_vaddr_alloc(),
> which currently are defined earlier in the file, so a forward
> declaration would be needed.
> 
> Instead, move it earlier in the file, just above vm_vaddr_alloc() and
> and friends, which are the main users.
> 
> Reviewed-by: Mingwei Zhang <mizhang@...gle.com>
> Signed-off-by: Michael Roth <michael.roth@....com>
> Signed-off-by: Peter Gonda <pgonda@...gle.com>
> ---
>  tools/testing/selftests/kvm/lib/kvm_util.c | 145 ++++++++++-----------
>  1 file changed, 72 insertions(+), 73 deletions(-)
>

Reviewed-by: Andrew Jones <andrew.jones@...ux.dev>