linux-kernel - Re: [PATCH] ASoC: imx-rpmsg: Support configure sysclk for codec dai

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <YukgUWgx+ZurQfBm@sirena.org.uk>
Date:   Tue, 2 Aug 2022 14:02:09 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Shengjiu Wang <shengjiu.wang@...il.com>
Cc:     Nicolin Chen <nicoleotsuka@...il.com>,
        Shengjiu Wang <shengjiu.wang@....com>,
        Xiubo Li <Xiubo.Lee@...il.com>,
        Fabio Estevam <festevam@...il.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: imx-rpmsg: Support configure sysclk for codec dai

On Tue, Aug 02, 2022 at 08:23:37PM +0800, Shengjiu Wang wrote:
> On Tue, Aug 2, 2022 at 1:47 AM Nicolin Chen <nicoleotsuka@...il.com> wrote:
> > On Mon, Aug 1, 2022 at 5:42 AM Shengjiu Wang <shengjiu.wang@....com>
> > wrote:

> > >  struct imx_rpmsg {
> > >         struct snd_soc_dai_link dai;
> > >         struct snd_soc_card card;
> > > +       unsigned int sysclk;

> > unsigned long?

> Seems int or long are all used in the kernel.
> I am not sure which one is better?

clk_get_rate() and clk_set_rate() do use unsigned long, but on a lot of
architectures that is the same size as int so it makes little practical
difference though it would be more correct to use an unsigned long.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)