lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 2 Aug 2022 22:04:13 +0800 From: Yu Kuai <yukuai1@...weicloud.com> To: tj@...nel.org, mkoutny@...e.com, axboe@...nel.dk, ming.lei@...hat.com Cc: cgroups@...r.kernel.org, linux-block@...r.kernel.org, linux-kernel@...r.kernel.org, yukuai3@...wei.com, yukuai1@...weicloud.com, yi.zhang@...wei.com Subject: [PATCH v7 7/9] blk-throttle: calling throtl_dequeue/enqueue_tg in pairs From: Yu Kuai <yukuai3@...wei.com> It's a little weird to call throtl_dequeue_tg() unconditionally in throtl_select_dispatch(), since it will be called in tg_update_disptime() again if some bio is still throttled. Thus call it later if there are no throttled bio. There are no functional changes. Signed-off-by: Yu Kuai <yukuai3@...wei.com> Acked-by: Tejun Heo <tj@...nel.org> --- block/blk-throttle.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/blk-throttle.c b/block/blk-throttle.c index 907001eede85..f7048f87b19f 100644 --- a/block/blk-throttle.c +++ b/block/blk-throttle.c @@ -1156,13 +1156,13 @@ static int throtl_select_dispatch(struct throtl_service_queue *parent_sq) if (time_before(jiffies, tg->disptime)) break; - throtl_dequeue_tg(tg); - nr_disp += throtl_dispatch_tg(tg); sq = &tg->service_queue; if (sq->nr_queued[READ] || sq->nr_queued[WRITE]) tg_update_disptime(tg); + else + throtl_dequeue_tg(tg); if (nr_disp >= THROTL_QUANTUM) break; -- 2.31.1
Powered by blists - more mailing lists