linux-kernel - Re: [PATCH v8 17/31] rust: add `kernel` crate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72=24xycLU0UU1oxn-7=Vk4hZBvZYh_RsnXFP1c5FyyxhQ@mail.gmail.com>
Date:   Tue, 2 Aug 2022 16:53:17 +0200
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Miguel Ojeda <ojeda@...nel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jarkko Sakkinen <jarkko@...nel.org>,
        Wedson Almeida Filho <wedsonaf@...gle.com>,
        Alex Gaynor <alex.gaynor@...il.com>,
        Geoffrey Thomas <geofft@...reload.com>,
        Finn Behrens <me@...enk.de>,
        Adam Bratschi-Kaye <ark.email@...il.com>,
        Michael Ellerman <mpe@...erman.id.au>,
        Sumera Priyadarsini <sylphrenadin@...il.com>,
        Sven Van Asbroeck <thesven73@...il.com>,
        Gary Guo <gary@...yguo.net>,
        Boris-Chengbiao Zhou <bobo1239@....de>,
        Boqun Feng <boqun.feng@...il.com>,
        Fox Chen <foxhlchen@...il.com>,
        Dan Robertson <daniel.robertson@...rlab.io>,
        Viktor Garske <viktor@...ar.de>,
        Dariusz Sosnowski <dsosnowski@...snowski.pl>,
        Léo Lanteri Thauvin <leseulartichaut@...il.com>,
        Niklas Mohrin <dev@...lasmohrin.de>,
        Gioh Kim <gurugio@...il.com>, Daniel Xu <dxu@...uu.xyz>,
        Milan Landaverde <milan@...verde.com>,
        Morgan Bartlett <mjmouse9999@...il.com>,
        Maciej Falkowski <m.falkowski@...sung.com>,
        Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        Nándor István Krácser <bonifaido@...il.com>,
        David Gow <davidgow@...gle.com>,
        John Baublitz <john.m.baublitz@...il.com>,
        Björn Roy Baron <bjorn3_gh@...tonmail.com>
Subject: Re: [PATCH v8 17/31] rust: add `kernel` crate

On Tue, Aug 2, 2022 at 4:36 PM Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
>
> I did?  Maybe I didn't realize we would end up with 15k lines of code
> from different parts of the kernel like amba bus and filesystem apis all
> in a single commit.  If so, my fault, but as other parts of this
> discussion show, it is going to be required to get the subsystem
> maintainers to be able to review the interfaces to their code in order
> to get any further.

No worries at all! Probably a misunderstanding on my side too.

I am more than happy to spit it into quite a few patches, and it will
also help with the C-d-b's.

As for reviewing -- since we keep adding abstractions and new features
to show how things may work, we would be chasing new reviews all the
time. Would it be better to drop some of those for the moment and get
the "core" in first?

That way we can merge each subsystem part by part later, send it to
the proper MLs as smaller patches, get maintainers on board, etc.
etc., and it would be more manageable for everyone.

Cheers,
Miguel