linux-kernel - Re: The r8188eu kernel module does not depend on the rtlwifi/rtl8188eufw.bin firmware file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c82114b6-1003-bfb5-0550-98dcbf1a3761@lwfinger.net>
Date:   Tue, 2 Aug 2022 10:01:58 -0500
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Grzegorz Szymaszek <gszymaszek@...rt.pl>, Greg KH <greg@...ah.com>,
        Phillip Potter <phil@...lpotter.co.uk>,
        linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: The r8188eu kernel module does not depend on the
 rtlwifi/rtl8188eufw.bin firmware file

On 8/2/22 09:17, Grzegorz Szymaszek wrote:
> On Tue, Aug 02, 2022 at 04:07:25PM +0200, Greg KH wrote:
>> Looks like someone needs to add a line to the driver that looks like:
>> 	MODULE_FIRMWARE("rtlwifi/rtl8188eufw.bin");
>> […] Can you make a patch that does this?
> 
> Sure, I will prepare and send one later (hopefully today), assuming no
> one objects in the meantime. Thanks for quick response.

There will be no objections. All 8188eu-based devices need that firmware. 
Omitting the MODULE_FIRMWARE macro was simply an oversight.

Larry