linux-kernel - RE: [v5,13/14] drm/i915/gsc: allocate extended operational memory in LMEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MN2PR11MB409353A658768E0B68CD70BAE59D9@MN2PR11MB4093.namprd11.prod.outlook.com>
Date:   Tue, 2 Aug 2022 18:49:35 +0000
From:   "Winkler, Tomas" <tomas.winkler@...el.com>
To:     "Teres Alexis, Alan Previn" <alan.previn.teres.alexis@...el.com>,
        "airlied@...ux.ie" <airlied@...ux.ie>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "Vivi, Rodrigo" <rodrigo.vivi@...el.com>,
        "joonas.lahtinen@...ux.intel.com" <joonas.lahtinen@...ux.intel.com>,
        "Usyskin, Alexander" <alexander.usyskin@...el.com>,
        "tvrtko.ursulin@...ux.intel.com" <tvrtko.ursulin@...ux.intel.com>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        "jani.nikula@...ux.intel.com" <jani.nikula@...ux.intel.com>
CC:     "intel-gfx@...ts.freedesktop.org" <intel-gfx@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Lubart, Vitaly" <vitaly.lubart@...el.com>
Subject: RE: [v5,13/14] drm/i915/gsc: allocate extended operational memory in
 LMEM

> 
> Looks good, just a minor nit.
> 
> Reviewed-by: Alan Previn <alan.previn.teres.alexis@...el.com>
> 
> 
> On Wed, 2022-07-06 at 14:43 +0300, Alexander Usyskin wrote:
> > From: Tomas Winkler <tomas.winkler@...el.com>
> >
> > GSC requires more operational memory than available on chip.
> > Reserve 4M of LMEM for GSC operation. The memory is provided to the
> > GSC as struct resource to the auxiliary data of the child device.
> >
> > Cc: Alan Previn <alan.previn.teres.alexis@...el.com>
> > Signed-off-by: Tomas Winkler <tomas.winkler@...el.com>
> > Signed-off-by: Daniele Ceraolo Spurio
> > <daniele.ceraolospurio@...el.com>
> > Signed-off-by: Alexander Usyskin <alexander.usyskin@...el.com>
> > ---
> >  drivers/gpu/drm/i915/gt/intel_gsc.c | 92
> > ++++++++++++++++++++++++++---  drivers/gpu/drm/i915/gt/intel_gsc.h
> |
> > 3 +
> >  2 files changed, 88 insertions(+), 7 deletions(-)
> >
> > +	if (def->lmem_size) {
> > +		dev_dbg(&pdev->dev, "setting up GSC lmem\n");

> >
> NIT: Any reason we are not being consistent and using drm_err / drm_debug
> (same below)? either way, ensuring we get PCI device id info in the dmesg
> output we are good.

Thanks, will fix.

> > +
> > +		if (gsc_ext_om_alloc(gsc, intf, def->lmem_size)) {
> > +			dev_err(&pdev->dev, "setting up gsc extended
> operational memory failed\n");
> > +			kfree(adev);
> > +			goto fail;
> > +		}
> > +
> > +		adev->ext_op_mem.start =
> i915_gem_object_get_dma_address(intf->gem_obj, 0);
> > +		adev->ext_op_mem.end = adev->ext_op_mem.start + def-
> >lmem_size;
> > +	}
> > +