lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Wed, 3 Aug 2022 13:13:10 +0800
From:   kernel test robot <lkp@...el.com>
To:     "Jason A. Donenfeld" <zx2c4@...nel.org>
Cc:     kbuild-all@...ts.01.org, Ammar Faizi <ammarfaizi2@...weeb.org>,
        GNU/Weeb Mailing List <gwml@...r.gnuweeb.org>,
        linux-kernel@...r.kernel.org
Subject: [ammarfaizi2-block:crng/random/jd/vdso 9/9] lib/crypto/chacha.c:28
 chacha_permute() warn: inconsistent indenting

tree:   https://github.com/ammarfaizi2/linux-block crng/random/jd/vdso
head:   29d7baa1e13b4304df93126e0c8baf56584b720a
commit: 29d7baa1e13b4304df93126e0c8baf56584b720a [9/9] random: implement getrandom() in vDSO
config: x86_64-randconfig-m001-20220801 (https://download.01.org/0day-ci/archive/20220803/202208031320.4h7OAbtq-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

smatch warnings:
lib/crypto/chacha.c:28 chacha_permute() warn: inconsistent indenting

vim +28 lib/crypto/chacha.c

1ca1b917940c24c lib/chacha.c   Eric Biggers  2018-11-16  24  
1ca1b917940c24c lib/chacha.c   Eric Biggers  2018-11-16  25  	for (i = 0; i < nrounds; i += 2) {
7660b1fb367eb37 lib/chacha20.c Eric Biggers  2017-12-31  26  		x[0]  += x[4];    x[12] = rol32(x[12] ^ x[0],  16);
7660b1fb367eb37 lib/chacha20.c Eric Biggers  2017-12-31  27  		x[1]  += x[5];    x[13] = rol32(x[13] ^ x[1],  16);
7660b1fb367eb37 lib/chacha20.c Eric Biggers  2017-12-31 @28  		x[2]  += x[6];    x[14] = rol32(x[14] ^ x[2],  16);
7660b1fb367eb37 lib/chacha20.c Eric Biggers  2017-12-31  29  		x[3]  += x[7];    x[15] = rol32(x[15] ^ x[3],  16);
e192be9d9a30555 lib/chacha20.c Theodore Ts'o 2016-06-12  30  
7660b1fb367eb37 lib/chacha20.c Eric Biggers  2017-12-31  31  		x[8]  += x[12];   x[4]  = rol32(x[4]  ^ x[8],  12);
7660b1fb367eb37 lib/chacha20.c Eric Biggers  2017-12-31  32  		x[9]  += x[13];   x[5]  = rol32(x[5]  ^ x[9],  12);
7660b1fb367eb37 lib/chacha20.c Eric Biggers  2017-12-31  33  		x[10] += x[14];   x[6]  = rol32(x[6]  ^ x[10], 12);
7660b1fb367eb37 lib/chacha20.c Eric Biggers  2017-12-31  34  		x[11] += x[15];   x[7]  = rol32(x[7]  ^ x[11], 12);
e192be9d9a30555 lib/chacha20.c Theodore Ts'o 2016-06-12  35  
7660b1fb367eb37 lib/chacha20.c Eric Biggers  2017-12-31  36  		x[0]  += x[4];    x[12] = rol32(x[12] ^ x[0],   8);
7660b1fb367eb37 lib/chacha20.c Eric Biggers  2017-12-31  37  		x[1]  += x[5];    x[13] = rol32(x[13] ^ x[1],   8);
7660b1fb367eb37 lib/chacha20.c Eric Biggers  2017-12-31  38  		x[2]  += x[6];    x[14] = rol32(x[14] ^ x[2],   8);
7660b1fb367eb37 lib/chacha20.c Eric Biggers  2017-12-31  39  		x[3]  += x[7];    x[15] = rol32(x[15] ^ x[3],   8);
e192be9d9a30555 lib/chacha20.c Theodore Ts'o 2016-06-12  40  
7660b1fb367eb37 lib/chacha20.c Eric Biggers  2017-12-31  41  		x[8]  += x[12];   x[4]  = rol32(x[4]  ^ x[8],   7);
7660b1fb367eb37 lib/chacha20.c Eric Biggers  2017-12-31  42  		x[9]  += x[13];   x[5]  = rol32(x[5]  ^ x[9],   7);
7660b1fb367eb37 lib/chacha20.c Eric Biggers  2017-12-31  43  		x[10] += x[14];   x[6]  = rol32(x[6]  ^ x[10],  7);
7660b1fb367eb37 lib/chacha20.c Eric Biggers  2017-12-31  44  		x[11] += x[15];   x[7]  = rol32(x[7]  ^ x[11],  7);
e192be9d9a30555 lib/chacha20.c Theodore Ts'o 2016-06-12  45  
7660b1fb367eb37 lib/chacha20.c Eric Biggers  2017-12-31  46  		x[0]  += x[5];    x[15] = rol32(x[15] ^ x[0],  16);
7660b1fb367eb37 lib/chacha20.c Eric Biggers  2017-12-31  47  		x[1]  += x[6];    x[12] = rol32(x[12] ^ x[1],  16);
7660b1fb367eb37 lib/chacha20.c Eric Biggers  2017-12-31  48  		x[2]  += x[7];    x[13] = rol32(x[13] ^ x[2],  16);
7660b1fb367eb37 lib/chacha20.c Eric Biggers  2017-12-31  49  		x[3]  += x[4];    x[14] = rol32(x[14] ^ x[3],  16);
e192be9d9a30555 lib/chacha20.c Theodore Ts'o 2016-06-12  50  
7660b1fb367eb37 lib/chacha20.c Eric Biggers  2017-12-31  51  		x[10] += x[15];   x[5]  = rol32(x[5]  ^ x[10], 12);
7660b1fb367eb37 lib/chacha20.c Eric Biggers  2017-12-31  52  		x[11] += x[12];   x[6]  = rol32(x[6]  ^ x[11], 12);
7660b1fb367eb37 lib/chacha20.c Eric Biggers  2017-12-31  53  		x[8]  += x[13];   x[7]  = rol32(x[7]  ^ x[8],  12);
7660b1fb367eb37 lib/chacha20.c Eric Biggers  2017-12-31  54  		x[9]  += x[14];   x[4]  = rol32(x[4]  ^ x[9],  12);
e192be9d9a30555 lib/chacha20.c Theodore Ts'o 2016-06-12  55  
7660b1fb367eb37 lib/chacha20.c Eric Biggers  2017-12-31  56  		x[0]  += x[5];    x[15] = rol32(x[15] ^ x[0],   8);
7660b1fb367eb37 lib/chacha20.c Eric Biggers  2017-12-31  57  		x[1]  += x[6];    x[12] = rol32(x[12] ^ x[1],   8);
7660b1fb367eb37 lib/chacha20.c Eric Biggers  2017-12-31  58  		x[2]  += x[7];    x[13] = rol32(x[13] ^ x[2],   8);
7660b1fb367eb37 lib/chacha20.c Eric Biggers  2017-12-31  59  		x[3]  += x[4];    x[14] = rol32(x[14] ^ x[3],   8);
e192be9d9a30555 lib/chacha20.c Theodore Ts'o 2016-06-12  60  
7660b1fb367eb37 lib/chacha20.c Eric Biggers  2017-12-31  61  		x[10] += x[15];   x[5]  = rol32(x[5]  ^ x[10],  7);
7660b1fb367eb37 lib/chacha20.c Eric Biggers  2017-12-31  62  		x[11] += x[12];   x[6]  = rol32(x[6]  ^ x[11],  7);
7660b1fb367eb37 lib/chacha20.c Eric Biggers  2017-12-31  63  		x[8]  += x[13];   x[7]  = rol32(x[7]  ^ x[8],   7);
7660b1fb367eb37 lib/chacha20.c Eric Biggers  2017-12-31  64  		x[9]  += x[14];   x[4]  = rol32(x[4]  ^ x[9],   7);
e192be9d9a30555 lib/chacha20.c Theodore Ts'o 2016-06-12  65  	}
dd333449d0fb667 lib/chacha20.c Eric Biggers  2018-11-16  66  }
dd333449d0fb667 lib/chacha20.c Eric Biggers  2018-11-16  67  

:::::: The code at line 28 was first introduced by commit
:::::: 7660b1fb367eb3723b48d3980451fc4f25a05021 crypto: chacha20 - use rol32() macro from bitops.h

:::::: TO: Eric Biggers <ebiggers@...gle.com>
:::::: CC: Herbert Xu <herbert@...dor.apana.org.au>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ