linux-kernel - Re: [PATCH linux-next] USB: apple-mfi-fastcharge:using the pm_runtime_resume_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YuoSx2Te30HxATlE@kroah.com>
Date:   Wed, 3 Aug 2022 08:16:39 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     cgel.zte@...il.com
Cc:     linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
        ye xingchen <ye.xingchen@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH linux-next] USB: apple-mfi-fastcharge:using the
 pm_runtime_resume_and_get to  simplify the code

On Wed, Aug 03, 2022 at 06:14:52AM +0000, cgel.zte@...il.com wrote:
> From: ye xingchen <ye.xingchen@....com.cn>
> 
> Using pm_runtime_resume_and_get() to instade of  pm_runtime_get_sync
> and pm_runtime_put_noidle.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@....com.cn>
> ---
>  drivers/usb/misc/apple-mfi-fastcharge.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/misc/apple-mfi-fastcharge.c b/drivers/usb/misc/apple-mfi-fastcharge.c
> index ac8695195c13..1bf9a67f4cca 100644
> --- a/drivers/usb/misc/apple-mfi-fastcharge.c
> +++ b/drivers/usb/misc/apple-mfi-fastcharge.c
> @@ -119,9 +119,8 @@ static int apple_mfi_fc_set_property(struct power_supply *psy,
>  
>  	dev_dbg(&mfi->udev->dev, "prop: %d\n", psp);
>  
> -	ret = pm_runtime_get_sync(&mfi->udev->dev);
> +	ret = pm_runtime_resume_and_get(&mfi->udev->dev);
>  	if (ret < 0) {
> -		pm_runtime_put_noidle(&mfi->udev->dev);
>  		return ret;
>  	}
>  
> -- 
> 2.25.1

For some reason you ignored my request in:
	https://lore.kernel.org/r/YujeLEMsIrVD2tGn@kroah.com 
so I'll just add your email to my discard list for a while, sorry.

greg k-h